From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbdBCVOj (ORCPT ); Fri, 3 Feb 2017 16:14:39 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34166 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbdBCVOh (ORCPT ); Fri, 3 Feb 2017 16:14:37 -0500 Subject: Re: [Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next To: akpm@linux-foundation.org References: <1d34eaa5-a506-8b7a-6471-490c345deef8@gmail.com> <2c29bd9f-5b67-02d0-18a3-8828e78bbb6f@gmail.com> <722b1cc4-93ac-dd8b-2be2-7a7e313b3b0b@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, dave.hansen@linux.intel.com, vbabka@suse.cz, mgorman@techsingularity.net, qiuxishi@huawei.com From: Yasuaki Ishimatsu Message-ID: Date: Fri, 3 Feb 2017 16:14:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <722b1cc4-93ac-dd8b-2be2-7a7e313b3b0b@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org TAB was replaced to white spaces. So please apply this one. --- From: Yasuaki Ishimatsu Date: Fri, 3 Feb 2017 15:18:03 -0500 Subject: [PATCH] mm/memory_hotplug: Remove unnecessary code from get_page_bootmem() The following patch is not applied correctly. http://lkml.kernel.org/r/2c29bd9f-5b67-02d0-18a3-8828e78bbb6f@gmail.com So the following unnecessary code still remains. void get_page_bootmem() { ... page->lru.next = (struct list_head *)type; ... The patch removes this code from get_page_bootmem() --- mm/memory_hotplug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 7409f25..d67787d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -179,7 +179,6 @@ static void release_memory_resource(struct resource *res) void get_page_bootmem(unsigned long info, struct page *page, unsigned long type) { - page->lru.next = (struct list_head *)type; page->freelist = (void *)type; SetPagePrivate(page); set_page_private(page, info); -- 1.8.3.1