LKML Archive on lore.kernel.org
 help / color / Atom feed
From: "Paraschiv, Andra-Irina" <andraprs@amazon.com>
To: kbuild test robot <lkp@intel.com>, <linux-kernel@vger.kernel.org>
Cc: <kbuild-all@lists.01.org>, Anthony Liguori <aliguori@amazon.com>,
	"Benjamin Herrenschmidt" <benh@amazon.com>,
	Colm MacCarthaigh <colmmacc@amazon.com>,
	Bjoern Doebel <doebel@amazon.de>,
	David Woodhouse <dwmw@amazon.co.uk>,
	"Frank van der Linden" <fllinden@amazon.com>,
	Alexander Graf <graf@amazon.de>,
	"Martin Pohlack" <mpohlack@amazon.de>,
	Matt Wilson <msw@amazon.com>
Subject: Re: [PATCH v1 14/15] nitro_enclaves: Add Makefile for the Nitro Enclaves driver
Date: Fri, 24 Apr 2020 18:27:07 +0300
Message-ID: <c7469263-fd17-1fd5-46b2-27d212de61e8@amazon.com> (raw)
In-Reply-To: <202004231644.xTmN4Z1z%lkp@intel.com>



On 23/04/2020 11:43, kbuild test robot wrote:
>
> Hi Andra,
>
> Thank you for the patch! Perhaps something to improve:

Fixed in v2.

Andra

>
> [auto build test WARNING on linus/master]
> [also build test WARNING on linux/master v5.7-rc2 next-20200422]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url:    https://github.com/0day-ci/linux/commits/Andra-Paraschiv/Add-support-for-Nitro-Enclaves/20200423-130814
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 18bf34080c4c3beb6699181986cc97dd712498fe
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>     In file included from include/linux/device.h:15:0,
>                      from drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:22:
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c: In function 'ne_submit_request':
>>> drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:80:9: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
>              "Invalid req size=%ld for cmd type=%d\n",
>              ^
>     include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
>      #define dev_fmt(fmt) fmt
>                           ^~~
>>> include/linux/dev_printk.h:167:3: note: in expansion of macro 'dev_err'
>        dev_level(dev, fmt, ##__VA_ARGS__);   \
>        ^~~~~~~~~
>     include/linux/dev_printk.h:177:2: note: in expansion of macro 'dev_level_ratelimited'
>       dev_level_ratelimited(dev_err, dev, fmt, ##__VA_ARGS__)
>       ^~~~~~~~~~~~~~~~~~~~~
>>> drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:79:3: note: in expansion of macro 'dev_err_ratelimited'
>        dev_err_ratelimited(&pdev->dev,
>        ^~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c: In function 'ne_retrieve_reply':
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:121:35: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
>        dev_err_ratelimited(&pdev->dev, "Invalid reply size=%ld\n",
>                                        ^
>     include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
>      #define dev_fmt(fmt) fmt
>                           ^~~
>>> include/linux/dev_printk.h:167:3: note: in expansion of macro 'dev_err'
>        dev_level(dev, fmt, ##__VA_ARGS__);   \
>        ^~~~~~~~~
>     include/linux/dev_printk.h:177:2: note: in expansion of macro 'dev_level_ratelimited'
>       dev_level_ratelimited(dev_err, dev, fmt, ##__VA_ARGS__)
>       ^~~~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:121:3: note: in expansion of macro 'dev_err_ratelimited'
>        dev_err_ratelimited(&pdev->dev, "Invalid reply size=%ld\n",
>        ^~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c: In function 'ne_do_request':
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:193:9: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
>              "Invalid req size=%ld for cmd type=%d\n",
>              ^
>     include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
>      #define dev_fmt(fmt) fmt
>                           ^~~
>>> include/linux/dev_printk.h:167:3: note: in expansion of macro 'dev_err'
>        dev_level(dev, fmt, ##__VA_ARGS__);   \
>        ^~~~~~~~~
>     include/linux/dev_printk.h:177:2: note: in expansion of macro 'dev_level_ratelimited'
>       dev_level_ratelimited(dev_err, dev, fmt, ##__VA_ARGS__)
>       ^~~~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:192:3: note: in expansion of macro 'dev_err_ratelimited'
>        dev_err_ratelimited(&pdev->dev,
>        ^~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:203:35: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
>        dev_err_ratelimited(&pdev->dev, "Invalid reply size=%ld\n",
>                                        ^
>     include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
>      #define dev_fmt(fmt) fmt
>                           ^~~
>>> include/linux/dev_printk.h:167:3: note: in expansion of macro 'dev_err'
>        dev_level(dev, fmt, ##__VA_ARGS__);   \
>        ^~~~~~~~~
>     include/linux/dev_printk.h:177:2: note: in expansion of macro 'dev_level_ratelimited'
>       dev_level_ratelimited(dev_err, dev, fmt, ##__VA_ARGS__)
>       ^~~~~~~~~~~~~~~~~~~~~
>     drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c:203:3: note: in expansion of macro 'dev_err_ratelimited'
>        dev_err_ratelimited(&pdev->dev, "Invalid reply size=%ld\n",
>        ^~~~~~~~~~~~~~~~~~~
>
> vim +80 drivers/virt/amazon/nitro_enclaves/ne_pci_dev.c
>
> 0ed609272739ee Andra Paraschiv 2020-04-21  42
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  43  /**
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  44   * ne_submit_request - Submit command request to the PCI device based on the
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  45   * command type.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  46   *
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  47   * This function gets called with the ne_pci_dev mutex held.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  48   *
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  49   * @pdev: PCI device to send the command to.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  50   * @cmd_type: command type of the request sent to the PCI device.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  51   * @cmd_request: command request payload.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  52   * @cmd_request_size: size of the command request payload.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  53   *
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  54   * @returns: 0 on success, negative return value on failure.
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  55   */
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  56  static int ne_submit_request(struct pci_dev *pdev,
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  57                        enum ne_pci_dev_cmd_type cmd_type,
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  58                        void *cmd_request, size_t cmd_request_size)
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  59  {
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  60   struct ne_pci_dev *ne_pci_dev = NULL;
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  61
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  62   BUG_ON(!pdev);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  63
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  64   ne_pci_dev = pci_get_drvdata(pdev);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  65   BUG_ON(!ne_pci_dev);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  66   BUG_ON(!ne_pci_dev->iomem_base);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  67
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  68   if (WARN_ON(cmd_type <= INVALID_CMD || cmd_type >= MAX_CMD)) {
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  69           dev_err_ratelimited(&pdev->dev, "Invalid cmd type=%d\n",
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  70                               cmd_type);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  71
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  72           return -EINVAL;
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  73   }
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  74
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  75   if (WARN_ON(!cmd_request))
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  76           return -EINVAL;
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  77
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  78   if (WARN_ON(cmd_request_size > NE_SEND_DATA_SIZE)) {
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21 @79           dev_err_ratelimited(&pdev->dev,
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21 @80                               "Invalid req size=%ld for cmd type=%d\n",
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  81                               cmd_request_size, cmd_type);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  82
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  83           return -EINVAL;
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  84   }
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  85
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  86   memcpy_toio(ne_pci_dev->iomem_base + NE_SEND_DATA, cmd_request,
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  87               cmd_request_size);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  88
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  89   iowrite32(cmd_type, ne_pci_dev->iomem_base + NE_COMMAND);
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  90
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  91   return 0;
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  92  }
> 08a5a524ab0b6c Andra Paraschiv 2020-04-21  93
>
> :::::: The code at line 80 was first introduced by commit
> :::::: 08a5a524ab0b6c939997c8d44b4d07e5ee97e91d nitro_enclaves: Handle PCI device command requests
>
> :::::: TO: Andra Paraschiv <andraprs@amazon.com>
> :::::: CC: 0day robot <lkp@intel.com>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


  reply index

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 18:41 [PATCH v1 00/15] Add support for Nitro Enclaves Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 01/15] nitro_enclaves: Add ioctl interface definition Andra Paraschiv
2020-04-21 18:47   ` Randy Dunlap
2020-04-21 21:45     ` Paolo Bonzini
2020-04-22 15:49       ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 02/15] nitro_enclaves: Define the PCI device interface Andra Paraschiv
2020-04-21 21:22   ` Paolo Bonzini
2020-04-23 13:37     ` Paraschiv, Andra-Irina
2020-04-24 15:10       ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 03/15] nitro_enclaves: Define enclave info for internal bookkeeping Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 04/15] nitro_enclaves: Init PCI device driver Andra Paraschiv
2020-04-25 14:25   ` Liran Alon
2020-04-29 16:31     ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 05/15] nitro_enclaves: Handle PCI device command requests Andra Paraschiv
2020-04-25 14:52   ` Liran Alon
2020-04-29 17:00     ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 06/15] nitro_enclaves: Handle out-of-band PCI device events Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 07/15] nitro_enclaves: Init misc device providing the ioctl interface Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 08/15] nitro_enclaves: Add logic for enclave vm creation Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 09/15] nitro_enclaves: Add logic for enclave vcpu creation Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 10/15] nitro_enclaves: Add logic for enclave memory region set Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 11/15] nitro_enclaves: Add logic for enclave start Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 12/15] nitro_enclaves: Add logic for enclave termination Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 13/15] nitro_enclaves: Add Kconfig for the Nitro Enclaves driver Andra Paraschiv
2020-04-21 18:50   ` Randy Dunlap
2020-04-22 14:35     ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 14/15] nitro_enclaves: Add Makefile " Andra Paraschiv
2020-04-23  8:12   ` kbuild test robot
2020-04-24 17:00     ` Paraschiv, Andra-Irina
2020-04-23  8:43   ` kbuild test robot
2020-04-24 15:27     ` Paraschiv, Andra-Irina [this message]
2020-04-21 18:41 ` [PATCH v1 15/15] MAINTAINERS: Add entry " Andra Paraschiv
2020-04-21 21:46 ` [PATCH v1 00/15] Add support for Nitro Enclaves Paolo Bonzini
2020-04-23 13:19   ` Paraschiv, Andra-Irina
2020-04-23 13:42     ` Paolo Bonzini
2020-04-23 17:42       ` Paraschiv, Andra-Irina
2020-04-23 17:51         ` Paolo Bonzini
2020-04-23 20:56           ` Alexander Graf
2020-04-23 21:18             ` Paolo Bonzini
2020-04-24 12:56               ` Alexander Graf
2020-04-24 16:27                 ` Paolo Bonzini
2020-04-24 19:11                   ` Alexander Graf
2020-04-25 16:05                     ` Paolo Bonzini
2020-04-27  9:15                       ` Paraschiv, Andra-Irina
2020-04-27  9:22                       ` Paraschiv, Andra-Irina
2020-04-27  9:46                         ` Paolo Bonzini
2020-04-27 10:00                           ` Paraschiv, Andra-Irina
2020-04-28 15:07                       ` Alexander Graf
2020-04-29 13:20                         ` Paolo Bonzini
2020-04-30 13:59                           ` Paraschiv, Andra-Irina
2020-04-30 10:34                         ` Paolo Bonzini
2020-04-30 11:21                           ` Alexander Graf
2020-04-30 11:38                             ` Paolo Bonzini
2020-04-30 11:47                               ` Alexander Graf
2020-04-30 11:58                                 ` Paolo Bonzini
2020-04-30 12:19                                   ` Alexander Graf
2020-05-07 17:44       ` Pavel Machek
2020-05-08  7:00         ` Paraschiv, Andra-Irina
2020-05-09 19:21           ` Pavel Machek
2020-05-10 11:02             ` Herrenschmidt, Benjamin
2020-05-11 10:49               ` Paraschiv, Andra-Irina
2020-05-11 13:49               ` Stefan Hajnoczi
2020-04-24  3:04     ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-04-24  8:19       ` Paraschiv, Andra-Irina
2020-04-24  9:54         ` Paraschiv, Andra-Irina
2020-04-26  1:55           ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-04-27 18:39             ` Paraschiv, Andra-Irina
2020-04-24  9:59     ` Tian, Kevin
2020-04-24 13:59       ` Paraschiv, Andra-Irina
2020-04-26  8:16         ` Tian, Kevin
2020-04-27 19:05           ` Paraschiv, Andra-Irina
     [not found]         ` <CAKXe6SLonLQLAOY9Q_2AzTeg4uJxiknsAWnJpTF0hMcXEG5Tew@mail.gmail.com>
2020-05-11 12:05           ` Paraschiv, Andra-Irina
2020-04-25 15:25     ` Liran Alon
2020-04-27  7:56       ` Paraschiv, Andra-Irina
2020-04-27 11:44         ` Liran Alon
2020-04-28 15:25           ` Alexander Graf
2020-04-28 16:01             ` Liran Alon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7469263-fd17-1fd5-46b2-27d212de61e8@amazon.com \
    --to=andraprs@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=benh@amazon.com \
    --cc=colmmacc@amazon.com \
    --cc=doebel@amazon.de \
    --cc=dwmw@amazon.co.uk \
    --cc=fllinden@amazon.com \
    --cc=graf@amazon.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mpohlack@amazon.de \
    --cc=msw@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git