From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161050AbcFMH4L (ORCPT ); Mon, 13 Jun 2016 03:56:11 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37197 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964841AbcFMH4I (ORCPT ); Mon, 13 Jun 2016 03:56:08 -0400 Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting To: Wanpeng Li References: <1465355110-21714-1-git-send-email-wanpeng.li@hotmail.com> <1465355110-21714-3-git-send-email-wanpeng.li@hotmail.com> Cc: "linux-kernel@vger.kernel.org" , kvm , Wanpeng Li , Ingo Molnar , "Peter Zijlstra (Intel)" , Rik van Riel , Thomas Gleixner , Frederic Weisbecker , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= From: Paolo Bonzini Message-ID: Date: Mon, 13 Jun 2016 09:55:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/2016 05:38, Wanpeng Li wrote: > + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap); > + steal_jiffies = jiffies_to_cputime(steal_account_process_tick(delta_jiffies)); Without jiffies_to_cputime here. Apart from this, yes, this is what I meant. Paolo > WARN_ON_ONCE(tsk->vtime_snap_whence == VTIME_INACTIVE); > tsk->vtime_snap = now; > > - return jiffies_to_cputime(delta); > + return jiffies_to_cputime(delta_jiffies - steal_jiffies);