From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amarula patchwork <linux-amarula@amarulasolutions.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
michael@amarulasolutions.com, Dario Binacchi <dariobin@libero.it>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4
Date: Tue, 23 Aug 2022 16:43:13 +0300 [thread overview]
Message-ID: <c74b4464-ec28-eff6-86e2-2b0e5e9e992b@linaro.org> (raw)
In-Reply-To: <20220820082936.686924-4-dario.binacchi@amarulasolutions.com>
On 20/08/2022 11:29, Dario Binacchi wrote:
> Add pin configurations for using CAN controller on stm32f469-disco
> board. They are located on the Arduino compatible connector CN5 (CAN1)
> and on the extension connector CN12 (CAN2).
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Do not ignore review. This is not correct. You are mixing copyright with
SoC...
>
> + can2_pins_b: can2-1 {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
> + bias-pull-up;
> + };
> + };
> +
Don't ignore review.
That's second one, so that's a no.. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-23 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 8:29 [RFC PATCH v2 0/4] can: bxcan: add support for ST bxCAN controller Dario Binacchi
2022-08-20 8:29 ` [RFC PATCH v2 1/4] dt-bindings: net: can: add STM32 bxcan DT bindings Dario Binacchi
2022-08-23 13:41 ` Krzysztof Kozlowski
2022-08-26 7:12 ` Dario Binacchi
2022-08-25 21:12 ` Rob Herring
2022-08-26 7:27 ` Dario Binacchi
2022-08-31 22:05 ` Rob Herring
2022-08-20 8:29 ` [RFC PATCH v2 2/4] ARM: dts: stm32: add CAN support on stm32f429 Dario Binacchi
2022-08-20 8:29 ` [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4 Dario Binacchi
2022-08-23 13:43 ` Krzysztof Kozlowski [this message]
2022-08-26 6:32 ` Dario Binacchi
2022-08-20 8:29 ` [RFC PATCH v2 4/4] can: bxcan: add support for ST bxCAN controller Dario Binacchi
2022-08-26 21:56 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c74b4464-ec28-eff6-86e2-2b0e5e9e992b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dariobin@libero.it \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=mkl@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).