From: Michael Straube <straube.linux@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8188eu: remove rtw_ioctl_rtl.h
Date: Sun, 1 Jul 2018 12:47:50 +0200 [thread overview]
Message-ID: <c76079d8-0745-8459-b40d-2bccadffbc69@gmail.com> (raw)
In-Reply-To: <CAHp75VcEXHbOAHgf5jTaP9ZP99wGFBVhXkuohsVd-cD6QQWBkQ@mail.gmail.com>
On 07/01/18 11:14, Andy Shevchenko wrote:
> On Sat, Jun 30, 2018 at 5:59 PM, Michael Straube
> <straube.linux@gmail.com> wrote:
>> The header rtw_ioctl_rtl.h is not used anywhere.
>> Running 'grep -r rtw_ioctl_rtl *' from kernel root
>> directory returns nothing, remove the file.
>
> Just a side note, using `git grep` is much more efficient against
> kernel source tree.
> Something like `git grep -n rtw_ioctl_rtl.h` in this case.
>
Ah, I did not know about `git grep`, thanks!
Michael
prev parent reply other threads:[~2018-07-01 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 14:59 [PATCH] staging: rtl8188eu: remove rtw_ioctl_rtl.h Michael Straube
2018-07-01 9:14 ` Andy Shevchenko
2018-07-01 10:47 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76079d8-0745-8459-b40d-2bccadffbc69@gmail.com \
--to=straube.linux@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).