From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801AbcIJO1l (ORCPT ); Sat, 10 Sep 2016 10:27:41 -0400 Received: from mout.web.de ([217.72.192.78]:56267 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437AbcIJO1i (ORCPT ); Sat, 10 Sep 2016 10:27:38 -0400 Subject: [PATCH 3/7] cfag12864b: Return directly if the driver "ks0108" was not initialized To: kernel-janitors@vger.kernel.org, Miguel Ojeda Sandonis References: <566ABCD9.1060404@users.sourceforge.net> <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 16:27:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DSLsjPpHkKbqz8ro8dkY3jkHT0kyZKpptKfZTxVc/P2qOvwYy9l B6tkn43fMK+v6rl35RH0i90ziUkTqH1M8xXrBMJL0ItFkBpZWs5x2zpyVM6y3W0Bvp/IN8p Q61WerHQfcmpRBnkgxz6ln9XtICYOIhfpBRZXzvP7bap/mbFVQjZhyvjrZdOj1CvttxDHPM gGoNTo26h0U/wtdssmKUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:bhEC6+cCsKs=:nv0bdIyc+BSm8NRnLEoYhT PoHdbRDcpn2mmfTLeAwlq66O9IkNgyRxyz3eSmqi5g8deDU0JhAHY9CV4DCUtkpchrrvaSRPA uMW6TRYwsoGszt9MmqmGrtStOSFSQOrEEjORKezzeAFEIPZUYv702F/B2pVJV77/UCNSAcJlK gTQpS+Ycbos4OpO9c/1rS3nuYfAPfl7NZVEUvRCW9K5d2EQuLQnFJSauXUooQbLn2686CrLWN 4xxr+U+Cjq0jYMLS4JesUvzi7WE3Yg3aDXxnYdo6wXe3Ysl/34Af2wxVnwwJnFWl+/F4ETq14 r74pFD7ickhvXjJcggM4FQdAolkQO3XkiLyXDvIiFJQw668NMD8Nwvx8EzLy8ZadNppL7EeLJ TY1wfJ5qRtvzgVyNIwi+eW7ObGQejDRA53SdWby+GsP7ho0cKksYg67npzZDD4pFPW+LbXylT 36imMA3XCEfZ0AcDkamy043WC95JJLWVRAGdZvUu5AXrXh79PabegX+IvlogNsY/Qkg7o3VT+ fc+LlmwGnVIM/kh+1Fn9BsCam0/DhgkwyD41z8r3iZYZZL2vnIz2z4eRyAr+UNrdJLooCayM4 wt/2TEqFWvElnwsrB0TFxFccdZpN1A3RE9o5TuhL2FolIIuj5noiKUr1Neg3V1YcgVR47nrA5 M+j3NhIo9KS2h6UsGCewcvUFoQKanqDbMXlzcgQu3KNSnQVzdGAtk8CyCeo4ypf0XOih1tMj9 lJ8ZHvclcypQhL13Wh/JhqYQVO+Sagj790YWx9lA+/ZQcIXKXQEuMmAjr5mYVjOddTfQ74ZyP 6tJXbmx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 15:15:10 +0200 * Return directly if the LCD controller driver was not initialized at the beginning. * Omit an explicit variable initialisation which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/auxdisplay/cfag12864b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index fd07fad..921e177 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -329,13 +329,13 @@ EXPORT_SYMBOL_GPL(cfag12864b_isinited); static int __init cfag12864b_init(void) { - int ret = -EINVAL; + int ret; /* ks0108_init() must be called first */ if (!ks0108_isinited()) { printk(KERN_ERR CFAG12864B_NAME ": ERROR: " "ks0108 is not initialized\n"); - goto none; + return -EINVAL; } BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE); -- 2.10.0