From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A39C433E7 for ; Sat, 10 Oct 2020 22:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 658922083B for ; Sat, 10 Oct 2020 22:51:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oDOJ/GnH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732746AbgJJWfo (ORCPT ); Sat, 10 Oct 2020 18:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730153AbgJJSyk (ORCPT ); Sat, 10 Oct 2020 14:54:40 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE00CC08EC25; Sat, 10 Oct 2020 10:48:17 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 10so184193pfp.5; Sat, 10 Oct 2020 10:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=UsvyoolCXPGifPPput5EkvxYqIiH/fv+ohqKnbks3LY=; b=oDOJ/GnHCr6v2RHN7CitzpPwAsdyNuQVzl1AmdPweTLbtzJF5YvAtlgHh+rWf1R5Q8 vU2NdYIlI22hDKgUHAkZ3zMAQ7goFtKHR+4hm5Pz3zCLyWDvYFVxfks3H4PyfkY3Au0y 1QWF9mC5UIE9s1pg0MSDMKnV2bx9ndgvDMZ/sDfODAossxH63zeiZJvfSLfjdMQtM56E L8JW2LKeyODqV/wi7xEKdm8xs4oyp7jMI2p734Gh9DSDjOZ7Nphx35klhJXZjOlp9B7/ GtHrFcrbxqBPUETOta6ulKS2PS30whxTqqd8e5MoSngklEjQV00awzXHmLwr7YgcHXCv L1rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UsvyoolCXPGifPPput5EkvxYqIiH/fv+ohqKnbks3LY=; b=ZXAoGORxz06f6528i8UvYDmSZVTsklRH+wBfsTy/V6YJ1lyqdMz9FMtTVRw2yHyfhz VKDQZapS/JKHbATlxWPVXXpfCBQjUzhuuw+oyuKj8JVYQwU81hPh9b8oCp8x6/9bzlv3 /nA7vRTbOfdv2Djy2mi2H9q71P7lUbr4n3UvwNFJa5/dvHO8WcUrYzqN+Lpslc6Cj4Gd AjmA9ZEGfda+V2qlNHfumlFtidHjpN77d4XMZePc+Kn9PvsoxetBiHlLjrXR+hAd7F+N nSE+jN3K/kEedBvz+t51BQb2UNiRlIPf8m5u8SNKE1+ivnaUKh7nkfxzKFplkCnOOYAF wl4A== X-Gm-Message-State: AOAM533VC/MhEw+sraLc2HVb7Fj+0TOxE3NCGJ6hAIZeUg6yGcnEXAqW dDldYxKkbF5OshOVebZ+ua+k61fnPcG3FL2+Fzo= X-Google-Smtp-Source: ABdhPJw7WCTIgQ8Skg+SBGmSpdINI/2sBT2t0utzFWNf3VFe7deMusnEM5z10SkPi1B2LyQcKIsYUA== X-Received: by 2002:a17:90a:e453:: with SMTP id jp19mr11518525pjb.34.1602352096486; Sat, 10 Oct 2020 10:48:16 -0700 (PDT) Received: from [192.168.0.104] ([49.207.200.2]) by smtp.gmail.com with ESMTPSA id g4sm14652311pgg.75.2020.10.10.10.48.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Oct 2020 10:48:15 -0700 (PDT) Subject: Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API To: Jakub Kicinski Cc: linux-kernel-mentees@lists.linuxfoundation.org, Oliver Neukum , "David S. Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201010065623.10189-1-anant.thazhemadam@gmail.com> <20201010100346.158cbf62@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Anant Thazhemadam Message-ID: Date: Sat, 10 Oct 2020 23:18:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201010100346.158cbf62@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/20 10:33 pm, Jakub Kicinski wrote: > On Sat, 10 Oct 2020 12:26:23 +0530 Anant Thazhemadam wrote: >> GPF_KERNEL > You haven't even built this, let alone tested :/ I'm really sorry about this. Turns out, my .config wasn't set generated by make allyesconfig, and thus this regression went undetected. I can submit a v2 that doesn't break the build, and which is build tested properly. However, I'm not clear on how else I could locally run unit tests pertaining to this patch. I understand the critical requirement for testing changes and would really appreciate it if someone could direct me towards some resource or another that could help me figure that out too. Once again, I'm really sorry for this oversight. Thank you for your time. Thanks, Anant