From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F8DC38159 for ; Wed, 18 Jan 2023 19:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbjARTQu (ORCPT ); Wed, 18 Jan 2023 14:16:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbjARTQs (ORCPT ); Wed, 18 Jan 2023 14:16:48 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F29166FE; Wed, 18 Jan 2023 11:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674069406; x=1705605406; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=kyLK2MQ6l6mvCoDXunF6Gzt2wFf1x80d2Y5A7KOX1NU=; b=NZU9LAmxfgz5Gi5onH2cXJJtTiwSitm7TmplXqcpLNnKNx3BvkJM1Qyn l6jKPqOZjfGK/Vxni2GaOHn8sGAavVzpsTWB+dY7l71gUwL16Rj3EL8Wh ZblwJk067dn822xLpJmpM1OVxm8OrsjSJAWg9fp4etEJwVxHO3GdKvigH yuYyr0kbrWMWrk/26BML48oTtuUa/629P2Ha5S/8dLTiNTorkPv6tn3Zj xIWjY+B9o9Z0G43ZQ2z2TOd84cQPATJrV4xWanLvLo128UUNDa7sqli7n WdoiSyBUsC/cWJH9JuhpaRJNN2sl73Jkyv0jZfaax2ZLg2PKrTVNHQaMP g==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="325126805" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="325126805" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 11:16:41 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="833707773" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="833707773" Received: from yzeleke-mobl1.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.209.16.158]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 11:16:41 -0800 Message-ID: Subject: Re: [PATCH v5 0/3] Thermal ACPI APIs for generic trip points From: srinivas pandruvada To: "Zhang, Rui" , "rafael@kernel.org" , "daniel.lezcano@linaro.org" Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "christophe.jaillet@wanadoo.fr" , "linux-acpi@vger.kernel.org" Date: Wed, 18 Jan 2023 11:16:41 -0800 In-Reply-To: <5aabdd3010a02e361fbbe01f4af0e30d11f0ae6b.camel@linux.intel.com> References: <20230113180235.1604526-1-daniel.lezcano@linaro.org> <2627c37e07dce6b125d3fea3bf38a5f2407ad6a1.camel@intel.com> <5aabdd3010a02e361fbbe01f4af0e30d11f0ae6b.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-01-18 at 11:01 -0800, srinivas pandruvada wrote: > On Wed, 2023-01-18 at 13:48 +0000, Zhang, Rui wrote: > > On Wed, 2023-01-18 at 10:53 +0100, Daniel Lezcano wrote: > > > Hi, > > > > > > On 13/01/2023 19:02, Daniel Lezcano wrote: > > > > Recently sent as a RFC, the thermal ACPI for generic trip > > > > points > > > > is > > > > a set of > > > > functions to fill the generic trip points structure which will > > > > become the > > > > standard structure for the thermal framework and its users. > > > > > > > > Different Intel drivers and the ACPI thermal driver are using > > > > the > > > > ACPI tables to > > > > get the thermal zone information. As those are getting the same > > > > information, > > > > providing this set of ACPI function with the generic trip > > > > points > > > > will > > > > consolidate the code. > > > > > > > > Also, the Intel PCH and the Intel 34xx drivers are converted to > > > > use > > > > the generic > > > > trip points relying on the ACPI generic trip point parsing > > > > functions. > > > > > > > > These changes have been tested on a Thinkpad Lenovo x280 with > > > > the > > > > PCH and > > > > INT34xx drivers. No regression have been observed, the trip > > > > points > > > > remain the > > > > same for what is described on this system. > > > > > > Are we ok with this series ? > > > > > > Sorry for insisting but I would like to go forward with the > > > generic > > > thermal trip work. There are more patches pending depending on > > > this > > > series. > > > > The whole series looks good to me. > > > > Reviwed-by: Zhang Rui > > > > But we'd better wait for the thermald test result from Srinvias. > > A quick test show that things still work with thermald and these > changes. But I have a question. In some devices trip point temperature is not static. When hardware changes, we get notification. For example INT3403_PERF_TRIP_POINT_CHANGED for INT3403 drivers. Currently get_trip can get the latest changed value. But if we preregister, we need some mechanism to update them. Thanks, Srinivas > Thanks, > Srinivas > > > > > thanks, > > rui > > > > > > Thanks > > >    -- Daniel > > > > > > > Changelog: > > > >   - V5: > > > >     - Fixed GTSH unit conversion, deciK -> milli C > > > > > > > >   - V4: > > > >     - Fixed Kconfig option dependency, select THERMAL_ACPI if > > > > ACPI > > > > is set > > > >       only for the PCH driver > > > > > > > >   - V3: > > > >     - Took into account Rafael's comments > > > >     - Used a silence option THERMAL_ACPI in order to stay > > > > consistent > > > >       with THERMAL_OF. It is up to the API user to select the > > > > option. > > > > > > > >   - V2: > > > >     - Fix the thermal ACPI patch where the thermal_acpi.c was > > > > not > > > > included in > > > >       the series > > > >     - Provide a couple of users of this API which could have > > > > been > > > > tested on a > > > >       real system > > > > > > > > Daniel Lezcano (3): > > > >    thermal/acpi: Add ACPI trip point routines > > > >    thermal/drivers/intel: Use generic trip points for intel_pch > > > >    thermal/drivers/intel: Use generic trip points int340x > > > > > > > >   drivers/thermal/Kconfig                       |   4 + > > > >   drivers/thermal/Makefile                      |   1 + > > > >   drivers/thermal/intel/Kconfig                 |   1 + > > > >   drivers/thermal/intel/int340x_thermal/Kconfig |   1 + > > > >   .../int340x_thermal/int340x_thermal_zone.c    | 177 ++++----- > > > > -- > > > > -- > > > > -- > > > >   .../int340x_thermal/int340x_thermal_zone.h    |  10 +- > > > >   drivers/thermal/intel/intel_pch_thermal.c     |  88 ++------ > > > >   drivers/thermal/thermal_acpi.c                | 210 > > > > ++++++++++++++++++ > > > >   include/linux/thermal.h                       |   8 + > > > >   9 files changed, 286 insertions(+), 214 deletions(-) > > > >   create mode 100644 drivers/thermal/thermal_acpi.c > > > > >