From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7639FC31E46 for ; Wed, 12 Jun 2019 11:11:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 506C520874 for ; Wed, 12 Jun 2019 11:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JyatqGuF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408961AbfFLLLx (ORCPT ); Wed, 12 Jun 2019 07:11:53 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39648 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407158AbfFLLLw (ORCPT ); Wed, 12 Jun 2019 07:11:52 -0400 Received: by mail-wr1-f67.google.com with SMTP id x4so13788810wrt.6 for ; Wed, 12 Jun 2019 04:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T0cZTEnUTvGGmjw5I8Wkm+xAGTXLp41aRjblrVtvO6s=; b=JyatqGuFCTR9C17AwuSyJvET6Y0x6fp6Y5k8x7KKvWEwZhzRSKNY+9DIRrM50+Om9Y WpMMP16n48yJ+G5mLjaHbe+AIIJrqRHDZXPYuhpIcfm1VjzPpUdxicueI0SOyL4HBkMt 3SOxQGDCQ/d0QJLUjQzOMtTSC6rQvOi7rCp94= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T0cZTEnUTvGGmjw5I8Wkm+xAGTXLp41aRjblrVtvO6s=; b=DzC7kN+7AKEmKy48WePdwg23ZPY/a5S/+DSO+FO4+7GUqOuPZV8N3eQ6rqCrZCUEYZ ZoR6ibnLbTNQiqVWFrY54i8mHNrkZxDALXFfKkQUBUszsFjaE4x/j0akbqs9h3d66LXo kulATvRFG4C+Q7DobKVbyOZEWfobTJICNWT0bw2gSoEhI8KdFPzuCCpDoUm3NFOA3xcs 0g1EMqO7QYXLqAVv4vOebbyEV7rfYvdZldE70+wXfjAd40tUHxCacYx9+gpgTurHUn1x VnA/hXhRqqqtMlgu8+uwLiXfS5biCR8SGE/Yz7zEz+LTY4CHP9Or5L7v00U9rKjlIrUo swYw== X-Gm-Message-State: APjAAAXUmIOHNXq6WSnG0iv+NtKcGJXpq+6lK+cnxMPNIXjE3BE8IXbx /DyBtBeEiS6KX2H1esagvMoKaQ== X-Google-Smtp-Source: APXvYqz8aasOCe6ye7E5FfdTBcDAkR84x/KcKfNBPauTc6i9sI0Ku3jNcSHbU+R9NjuSPf/RBBPEVA== X-Received: by 2002:adf:f8cf:: with SMTP id f15mr40008967wrq.333.1560337909649; Wed, 12 Jun 2019 04:11:49 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id 5sm5337449wmg.7.2019.06.12.04.11.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2019 04:11:48 -0700 (PDT) Subject: Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail To: Ulf Hansson , Doug Anderson Cc: "Hunter, Adrian" , Kalle Valo , "brcm80211-dev-list.pdl@broadcom.com" , "linux-rockchip@lists.infradead.org" , Double Lo , "briannorris@chromium.org" , "linux-wireless@vger.kernel.org" , Naveen Gupta , Madhan Mohan R , "mka@chromium.org" , Wright Feng , Chi-Hsien Lin , "netdev@vger.kernel.org" , "brcm80211-dev-list@cypress.com" , Franky Lin , "linux-kernel@vger.kernel.org" , Hante Meuleman , YueHaibing , "David S. Miller" References: <20190607223716.119277-1-dianders@chromium.org> <20190607223716.119277-4-dianders@chromium.org> <363DA0ED52042842948283D2FC38E4649C52F8A0@IRSMSX106.ger.corp.intel.com> From: Arend Van Spriel Message-ID: Date: Wed, 12 Jun 2019 13:11:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/2019 12:10 PM, Ulf Hansson wrote: >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: >> mmc_set_data_timeout(md, func->card); >> mmc_wait_for_req(func->card->host, mr); > These are not okay, none of these things calls should really be done > from an SDIO func driver. > > It tells me that the func driver is a doing workaround for something > that should be managed in a common way. We are using some low-level functions passing chain of skbuff to the device using CMD53 with scatterlist. If I recall correctly Marvell made an attempt to have a similar function for it in the mmc stack. Not sure if that ever made it in. If so I can rework our driver using that API. If not, I can make a new attempt. Regards, Arend