From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
luto@kernel.org, Jiufei Xue <jiufei.xue@linux.alibaba.com>,
Xu Yu <xuyu@linux.alibaba.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org
Subject: Re: [bug report][stable] perf probe: failed to add events
Date: Tue, 26 Feb 2019 20:32:34 +0800 [thread overview]
Message-ID: <c7ccd9cb-3a66-98a9-faa1-7ee5ed20ff88@linux.alibaba.com> (raw)
In-Reply-To: <20190226090505.GA24409@kroah.com>
On 19/2/26 17:05, Greg KH wrote:
> On Tue, Feb 26, 2019 at 03:31:14PM +0800, Joseph Qi wrote:
>> Hi,
>>
>> I'm using kernel v4.19.24 and have found that there is an issue when
>> using perf probe to define a new dynamic tracepoint.
>>
>> $ perf probe -a handle_mm_fault
>> Failed to write event: Numerical result out of range
>> Error: Failed to add events.
>>
>> I've also tried kernel v4.20, and it can pass.
>
> Ick, has this ever worked on the 4.19 stable tree? If so, any chance
> you can run 'git bisect' to find the offending commit?
>
From my test, v4.19.0 also has this issue.
Bisect locates that it is introduced by commit bf904d2762ee
"x86/pti/64: Remove the SYSCALL64 entry trampoline".
Thanks,
Joseph
>> So I've bisected and finally found the first good commit is:
>> bf904d2762ee x86/pti/64: Remove the SYSCALL64 entry trampoline
>> which is based on another commit:
>> 98f05b5138f0 Use the TSS sp2 slot for SYSCALL/SYSRET scratch space
>>
>> Once I've backpoted these two commits into 4.19.24, the above case can
>> pass, though I'm not sure how it is fixed.
>> So is there any plan to let them go into stable as well?
>
> If they are needed, I'll gladly queue them up, but this feels like
> something might have broken, so it should be easier to just revert the
> offending commit instead.
>
> Andy, any ideas?
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2019-02-26 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 7:31 [bug report][stable] perf probe: failed to add events Joseph Qi
2019-02-26 9:05 ` Greg KH
2019-02-26 12:32 ` Joseph Qi [this message]
2019-02-26 13:08 ` Greg KH
2019-02-26 14:20 ` Arnaldo Carvalho de Melo
2019-02-27 12:39 ` Adrian Hunter
2019-02-28 2:07 ` Joseph Qi
2019-02-28 7:19 ` Adrian Hunter
2019-03-02 10:58 ` Joseph Qi
2019-03-04 13:13 ` [PATCH] perf probe: Fix getting the kernel map Adrian Hunter
2019-03-08 14:39 ` Arnaldo Carvalho de Melo
2019-03-11 9:23 ` Masami Hiramatsu
2019-03-22 22:01 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2019-03-21 10:10 ` [bug report][stable] perf probe: failed to add events Greg KH
2019-03-25 10:02 ` Adrian Hunter
2019-02-27 1:53 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ccd9cb-3a66-98a9-faa1-7ee5ed20ff88@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=acme@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiufei.xue@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).