From: 谢泓宇 <xiehongyu1@kylinos.cn>
To: Greg KH <gregkh@linuxfoundation.org>, Hongyu Xie <xy521521@gmail.com>
Cc: mathias.nyman@intel.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, 125707942@qq.com,
stable@vger.kernel.org
Subject: Re: [PATCH -next] xhci: fix two places when dealing with return value of function xhci_check_args
Date: Wed, 26 Jan 2022 18:22:45 +0800 [thread overview]
Message-ID: <c7f6a8bb-76b6-cd2d-7551-b599a8276f5c@kylinos.cn> (raw)
In-Reply-To: <YfEZFtf9K8pFC8Mw@kroah.com>
1."What problem?
r8152_submit_rx needs to detach netdev if -ENODEV happened, but -ENODEV
will never happen
because xhci_urb_enqueue only returns -EINVAL if the return value of
xhci_check_args <= 0. So
r8152_submit_rx will will call napi_schedule to re-submit that urb, and
this will cause infinite urb
submission.
The whole point is, if xhci_check_args returns value A,
xhci_urb_enqueque shouldn't return any
other value, because that will change some driver's behavior(like r8152.c).
2."So if 0 is returned, you will now return that here, is that ok?
That is a change in functionality.
But this can only ever be the case for a root hub, is that ok?"
It's the same logic, but now xhci_urb_enqueue can return -ENODEV if xHC
is halted.
If it happens on a root hub, xhci_urb_enqueue won't be called.
3."Again, this means all is good? Why is this being called for a root hub?"
It is the same logic with the old one, but now
xhci_check_streams_endpoint can return -ENODEV if xHC is halted.
thanks
Hongyu Xie
On Tue, 25 Jan 2022 at 22:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Wed, Jan 26, 2022 at 05:41:26PM +0800, Hongyu Xie wrote:
>> From: Hongyu Xie <xiehongyu1@kylinos.cn>
>>
>> xhci_check_args returns 4 types of value, -ENODEV, -EINVAL, 1 and 0.
>> xhci_urb_enqueue and xhci_check_streams_endpoint return -EINVAL if
>> the return value of xhci_check_args <= 0.
>> This will cause a problem.
> What problem?
>
>> For example, r8152_submit_rx calling usb_submit_urb in
>> drivers/net/usb/r8152.c.
>> r8152_submit_rx will never get -ENODEV after submiting an urb
>> when xHC is halted,
>> because xhci_urb_enqueue returns -EINVAL in the very beginning.
>>
>> Fixes: 203a86613fb3 ("xhci: Avoid NULL pointer deref when host dies.")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
>> ---
>> drivers/usb/host/xhci.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index dc357cabb265..a7a55dd206fe 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -1604,9 +1604,12 @@ static int xhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flag
>> struct urb_priv *urb_priv;
>> int num_tds;
>>
>> - if (!urb || xhci_check_args(hcd, urb->dev, urb->ep,
>> - true, true, __func__) <= 0)
>> + if (!urb)
>> return -EINVAL;
>> + ret = xhci_check_args(hcd, urb->dev, urb->ep,
>> + true, true, __func__);
>> + if (ret <= 0)
>> + return ret;
> So if 0 is returned, you will now return that here, is that ok?
> That is a change in functionality.
>
> But this can only ever be the case for a root hub, is that ok?
>
>>
>> slot_id = urb->dev->slot_id;
>> ep_index = xhci_get_endpoint_index(&urb->ep->desc);
>> @@ -3323,7 +3326,7 @@ static int xhci_check_streams_endpoint(struct xhci_hcd *xhci,
>> return -EINVAL;
>> ret = xhci_check_args(xhci_to_hcd(xhci), udev, ep, 1, true, __func__);
>> if (ret <= 0)
>> - return -EINVAL;
>> + return ret;
> Again, this means all is good? Why is this being called for a root hub?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2022-01-26 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 9:41 [PATCH -next] xhci: fix two places when dealing with return value of function xhci_check_args Hongyu Xie
2022-01-26 9:49 ` Greg KH
2022-01-26 10:22 ` 谢泓宇 [this message]
2022-01-26 10:50 ` Greg KH
2022-01-26 12:49 ` Hongyu Xie
2022-01-27 9:43 ` Mathias Nyman
2022-01-28 3:48 ` 谢泓宇
2022-01-28 9:48 ` Mathias Nyman
2022-02-09 2:47 ` 谢泓宇
-- strict thread matches above, loose matches on Subject: below --
2022-01-26 8:56 Hongyu Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f6a8bb-76b6-cd2d-7551-b599a8276f5c@kylinos.cn \
--to=xiehongyu1@kylinos.cn \
--cc=125707942@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
--cc=xy521521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).