From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998ABC2D0C3 for ; Mon, 16 Dec 2019 13:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65CF320684 for ; Mon, 16 Dec 2019 13:52:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jKAiVvUH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728005AbfLPNwC (ORCPT ); Mon, 16 Dec 2019 08:52:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33038 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727894AbfLPNwC (ORCPT ); Mon, 16 Dec 2019 08:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576504320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92SYUSBikdk3xyYnFqKeAftGqF8EgbhEnCGGofd5R5U=; b=jKAiVvUHujBgxAAJrriAUkZ+y1qKEEeuNMBvLE3Buy8vLRwgUxUuN6xGea3Dhx+xiJTl9L xXKyxW5vPZ9MMJxIVVnQEJmT0kKNr1bnfQtjreEhuR96akiHIVJBzOcnO6aTDaoEpv+HHd xRJoKFIEN8S+zOTU15WePoCmV8dGazY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-gtg3udXcNzqLHPobwwX1Ww-1; Mon, 16 Dec 2019 08:51:59 -0500 X-MC-Unique: gtg3udXcNzqLHPobwwX1Ww-1 Received: by mail-wr1-f72.google.com with SMTP id o6so2626686wrp.8 for ; Mon, 16 Dec 2019 05:51:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=92SYUSBikdk3xyYnFqKeAftGqF8EgbhEnCGGofd5R5U=; b=mY5ISbG+n48uGO9lBTwJyIrO29ltATVyvUWohsYSUe5x02jvu41edUBT5QYGJZFXI7 RPA6FmDYVw3GCEa2AXq7e/0EZFY5292I4PoFL7kdfzSHUQkk8AfH2EpFxGhmgJ1mvyqS ID+RRkToKyWMXt0IZpLj/+if2jIq7zszHb1QoRViMpWuF/plKBcRbRbmJMmk6nh4G8/n k2UiNVcJrRVTezwxVOtKIbf5sIjLDYaRpBEA1I21rlLrgkT38hwwXHY60GKXX0GxPiFW gcC6aQk3BHQ8AfjmPSIHBOmUKwhEgwMeVKf00OxwrWkxRDzc2aWIW8dCMUxnLaR3bnei 7dQA== X-Gm-Message-State: APjAAAXjOnOyRiEQloUVsfzSqLwivFQWCbESLwCJ5/zdb2jwyK+H5EEB TIQCj4VJxg70o2UvmHHDvRXO9ps6NIj4GnTp+Ij/lZ9rXQv5mX1qVy1s+Fc2n75+NOJS+mY/LoC dGEiBy3b7j13Uc6byLXgDqTO9 X-Received: by 2002:a05:600c:224d:: with SMTP id a13mr31393737wmm.57.1576504316478; Mon, 16 Dec 2019 05:51:56 -0800 (PST) X-Google-Smtp-Source: APXvYqwyxMC8rOEm3cQf/zGU6nzBkVtCLQ2bPDjiwI95jk9Cscpkz7pIDerHyRW1DrZwA6GRaoPVeQ== X-Received: by 2002:a05:600c:224d:: with SMTP id a13mr31393720wmm.57.1576504316212; Mon, 16 Dec 2019 05:51:56 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id o66sm17703254wmo.20.2019.12.16.05.51.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 05:51:55 -0800 (PST) Subject: Re: [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Lee Jones , Linus Walleij , intel-gfx , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20191215163810.52356-1-hdegoede@redhat.com> <20191215163810.52356-4-hdegoede@redhat.com> <20191216134551.GQ1208@intel.com> From: Hans de Goede Message-ID: Date: Mon, 16 Dec 2019 14:51:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191216134551.GQ1208@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thank you for the reviews. On 16-12-2019 14:45, Ville Syrjälä wrote: > On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote: >> When the LCD has not been turned on by the firmware/GOP, because e.g. the >> device was booted with an external monitor connected over HDMI, we should >> not turn on the panel-enable GPIO when we request it. >> >> Turning on the panel-enable GPIO when we request it, means we turn it on >> too early in the init-sequence, which causes some panels to not correctly >> light up. >> >> This commits adds a panel_is_on parameter to intel_dsi_vbt_gpio_init() >> and makes intel_dsi_vbt_gpio_init() set the initial GPIO value accordingly. >> >> This fixes the panel not lighting up on a Thundersoft TST168 tablet when >> booted with an external monitor connected over HDMI. >> >> Signed-off-by: Hans de Goede >> --- >> drivers/gpu/drm/i915/display/intel_dsi.h | 2 +- >> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 7 +++---- >> drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- >> 3 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h >> index de7e51cd3460..675771ea91aa 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dsi.h >> +++ b/drivers/gpu/drm/i915/display/intel_dsi.h >> @@ -203,7 +203,7 @@ void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port); >> >> /* intel_dsi_vbt.c */ >> bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); >> -void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi); >> +void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); >> void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); >> void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, >> enum mipi_seq seq_id); >> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> index 5352e8c9eca5..027970348b22 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> @@ -688,17 +688,16 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id) >> * On some BYT/CHT devs some sequences are incomplete and we need to manually >> * control some GPIOs. >> */ >> -void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi) >> +void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) >> { >> struct drm_device *dev = intel_dsi->base.base.dev; >> struct drm_i915_private *dev_priv = to_i915(dev); >> struct mipi_config *mipi_config = dev_priv->vbt.dsi.config; >> + enum gpiod_flags flags = panel_is_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW; > > Can't we just tell it not to change the current setting? We could use GPIOD_ASIS for that, but with the SoC pins (when the PMIC is not used for backlight control) things get a bit muddy, I've seen several instances of this message from drivers/pinctrl/intel/pinctrl-baytrail.c trigger when the GOP did not init the panel: dev_warn(vg->dev, FW_BUG "pin %u forcibly re-configured as GPIO\n", offset); And in that case with GPIOD_ASIS I have no idea which we initially get, so this approach, where we clearly define which initial value we want, seems better. Regards, Hans p.s. The intel-gfx CI seems to seriously dislike my patches lately, almost always failing them; and usually on what at least seem to be unrelated test-cases. Any advice on how to deal with this? > >> >> if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) && >> (mipi_config->pwm_blc == PPS_BLC_PMIC)) { >> - intel_dsi->gpio_panel = >> - gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH); >> - >> + intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags); >> if (IS_ERR(intel_dsi->gpio_panel)) { >> DRM_ERROR("Failed to own gpio for panel control\n"); >> intel_dsi->gpio_panel = NULL; >> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c >> index 178d0fffba5b..e86e4a11e199 100644 >> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c >> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c >> @@ -1910,7 +1910,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv) >> >> vlv_dphy_param_init(intel_dsi); >> >> - intel_dsi_vbt_gpio_init(intel_dsi); >> + intel_dsi_vbt_gpio_init(intel_dsi, current_mode != NULL); >> >> drm_connector_init(dev, connector, &intel_dsi_connector_funcs, >> DRM_MODE_CONNECTOR_DSI); >> -- >> 2.23.0 >