From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2CD7C07E9C for ; Thu, 8 Jul 2021 08:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B43B61CE5 for ; Thu, 8 Jul 2021 08:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbhGHIqN (ORCPT ); Thu, 8 Jul 2021 04:46:13 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:49906 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbhGHIqN (ORCPT ); Thu, 8 Jul 2021 04:46:13 -0400 Received: from [192.168.1.111] (91-158-153-130.elisa-laajakaista.fi [91.158.153.130]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 574A6E7; Thu, 8 Jul 2021 10:43:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625733809; bh=6IvbrqMxcjh3DQkYpu4PYqeYQ0WmbHNAr/A4z7dJgaY=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=o3CHoxkQAgl1tfEqTcVMpsAwQnPChF+FNEjOu5o3JLEBbhwB5pmvOotEeDgQCWMdb RJTypBZkEWNQQzpM2+lL6YakbyTpxWvuCfP5mt3bwsabKBX9Pnvdm5Suo2sll+x0lu XMExrSY7tURTyAK+xwocqEe4IpakjLXU1OzGTqIU= To: Jacopo Mondi , Pratyush Yadav Cc: Mauro Carvalho Chehab , Laurent Pinchart , Vignesh Raghavendra , Nikhil Devshatwar , Alexandre Courbot , Arnd Bergmann , Benoit Parrot , Bert Vermeulen , Dikshita Agarwal , Dongchun Zhu , Eugen Hristev , Ezequiel Garcia , Fabio Estevam , Georgi Djakov , Hans Verkuil , Helen Koike , Jacopo Mondi , Jiapeng Chong , Kieran Bingham , Kieran Bingham , Lad Prabhakar , Martina Krasteva , Maxime Ripard , Michael Tretter , Mirela Rabulea , Neil Armstrong , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Paul Kocialkowski , Qiushi Wu , Raag Jadav , Ricardo Ribalda , Rob Herring , Sakari Ailus , Stanimir Varbanov , Steve Longerbeam , Thomas Bogendoerfer , Tianshu Qiu , Yang Yingliang , Zou Wei , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20210624192200.22559-1-p.yadav@ti.com> <20210707185636.xxu6n6p4gihrs37d@ti.com> <20210708081919.rlp5xv5f4jbx6uav@uno.localdomain> From: Tomi Valkeinen Subject: Re: [PATCH v3 00/11] CSI2RX support on J721E Message-ID: Date: Thu, 8 Jul 2021 11:43:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708081919.rlp5xv5f4jbx6uav@uno.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2021 11:19, Jacopo Mondi wrote: > Hi Tomi, Pratyush, > > On Thu, Jul 08, 2021 at 12:26:38AM +0530, Pratyush Yadav wrote: >> Hi Tomi, >> >> Thanks for looking into the patches. >> >> On 01/07/21 10:56AM, Tomi Valkeinen wrote: >>> Hi Pratyush, >>> >>> On 24/06/2021 22:21, Pratyush Yadav wrote: >>>> Hi, >>>> >>>> This series adds support for CSI2 capture on J721E. It includes some >>>> fixes to the Cadence CSI2RX driver, adds runtime PM support to OV5640 >>>> driver, and finally adds the TI CSI2RX wrapper driver. >>>> >>>> This series used to include the DPHY and DMA engine patches as well, but >>>> they have been split off to facilitate easier merging. Patch 3 is >>>> build-dependent on the DPHY series [0]. >>>> >>>> The DMA engine patch [1] can go in any order since that is only a run >>>> time dependency. Things probably won't work without it but it will still >>>> build fine. >>>> >>>> Tested on TI's J721E with OV5640 sensor. >>> >>> I applied these (csi-2 rx, phy, dma-engine) to linux-media/master, and added dts changes to add the csi2-rx. When sending the series, can you also push the branch you use for testing, as the posted patches do not include everything needed? >> >> Please use https://github.com/prati0100/linux-next/ branch "capture" >> >> I will include the link in the cover letter from next version onwards. >> >>> >>> Here are some notes from quick tests: >>> >>> Capture works, but the fps is ~28.98. I would expect it to be closer to 30. Are the clocks configured correctly? >> >> I see this as well. I figured this had something to do with the sensor. > > Tomi you might remember your patch to change the h/vtot values which I > collected in a series which I never managed to bring to v1, as Hugues > reported it was broken for JPEG capture. > > I'll leave it here just for reference, I admit I dropped the ball > rather quickly there: > https://patchwork.linuxtv.org/project/linux-media/cover/20201028225706.110078-1-jacopo+renesas@jmondi.org/ > > I wish I could re-test but seems I've lost the powering cable of the > device I used to test ov5640 :( Yes, I'm still using my hack patch when working with OV5640. With that hack, on TI platforms with CAL IP, I get ~30fps. With this series on J7, I get the above mentioned 28.98. It's possible my hack patch is wrong, and CAL driver is buggy, but together they make things right. I guess I should also try J7 without my hack patch. If I recall right, I tested your changes but I couldn't get them to work on my HW. I haven't worked on that since then, as I decided that debugging blind is pointless. We need someone to analyze the signals to see what OV5640 is sending. Or some new understanding about the OV5640 HW. Tomi