From: Hans de Goede <hdegoede@redhat.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Li Jun <jun.li@nxp.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Min Guo <min.guo@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B
Date: Mon, 11 Mar 2019 09:06:36 +0100 [thread overview]
Message-ID: <c8084259-74d3-c85f-1275-854826c935a0@redhat.com> (raw)
In-Reply-To: <1552282383.10179.21.camel@mhfsdcap03>
Hi,
On 11-03-19 06:33, Chunfeng Yun wrote:
> Hi,
>
> On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 08-03-19 07:13, Chunfeng Yun wrote:
>>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
>>> usb-b-connector
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>> ---
>>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
>>> index a9a2f2fc44f2..7a07b0f4f973 100644
>>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
>>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
>>> @@ -17,6 +17,16 @@ Optional properties:
>>> - self-powered: Set this property if the usb device that has its own power
>>> source.
>>>
>>> +Optional properties for usb-b-connector:
>>> +- id-gpios: gpio for USB ID pin.
>>
>> What about boards where the ID pin is *not* connected to a GPIO,
>> but e.g. to a special pin on the PMIC which can also detect
>> an ACA adapter ? Currently this case is handled by extcon
>> drivers, but we have no way to set e.g. vbus-supply for the
>> connector. Maybe in this case the usb-connector node should
>> be a child of the PMIC node ?
> Yes, it would be, PMIC is in charger of detecting the status of ID pin
Ok, then I think this should be documented too.
>> And in many cases there also is a mux to switch the datalines
>> between the host and device(gadget) controllers, how should
>> that be described in this model? See the new usb-role-switch
>> code under drivers/usb/roles
>>
>> In some cases the mux is controlled through a gpio, so we
>> may want to add a "mux-gpios" here in which case we also
>> need to define what 0/1 means.
> I'm not sure, the mux seems not belong to this connector,
> and may need another driver to register usb-role-switch,
> similar to:
>
> [v2,2/2] usb: typec: add typec switch via GPIO control
> https://patchwork.kernel.org/patch/10834327/
Right the mux/role-switch will need a driver, but the "owner"
of the usb_connector, e.g. the PMIC or the owner of the
id GPIO pin needs to know which device is the role-switch so
that it can set the role correctly based on the id-pin.
Your binding already contains Vbus info, allowing the owner
of the usb_connector to enable/disable Vbus based on the id-pin,
but the owner will also be responsible for setting the role-switch.
Note we cannot simply assume there will be only one role-switch,
we really need some link from the usb_connector to the role-switch
(or if it is a GPIO driven role-switch simply a role-switch-gpios
member in the usb_connector).
Regards,
Hans
next prev parent reply other threads:[~2019-03-11 8:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 6:13 [PATCH 0/5] add USB Type-B connector driver Chunfeng Yun
2019-03-08 6:13 ` [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-03-08 12:07 ` Hans de Goede
2019-03-11 5:33 ` Chunfeng Yun
2019-03-11 6:06 ` Jun Li
2019-03-11 6:43 ` Chunfeng Yun
2019-03-11 8:06 ` Hans de Goede [this message]
2019-03-11 11:00 ` Hans de Goede
2019-03-11 11:04 ` Hans de Goede
2019-03-12 2:18 ` Chunfeng Yun
2019-03-12 3:18 ` Chunfeng Yun
2019-03-12 12:45 ` Hans de Goede
2019-03-13 10:15 ` Chunfeng Yun
2019-03-13 10:18 ` Hans de Goede
2019-03-14 2:05 ` Chunfeng Yun
2019-03-08 6:13 ` [PATCH 2/5] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-03-08 6:13 ` [PATCH 3/5] usb: roles: add API to get usb_role_switch by node Chunfeng Yun
2019-03-08 6:52 ` Andy Shevchenko
2019-03-11 5:36 ` Chunfeng Yun
2019-03-08 6:13 ` [PATCH 4/5] usb: roles: add USB Type-B connector driver Chunfeng Yun
2019-03-08 6:13 ` [PATCH 5/5] usb: mtu3: register a USB Role Switch for Dual-Role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8084259-74d3-c85f-1275-854826c935a0@redhat.com \
--to=hdegoede@redhat.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).