From: Larry Finger <Larry.Finger@lwfinger.net>
To: Grzegorz Szymaszek <gszymaszek@short.pl>,
Greg KH <greg@kroah.com>, Phillip Potter <phil@philpotter.co.uk>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: The r8188eu kernel module does not depend on the rtlwifi/rtl8188eufw.bin firmware file
Date: Tue, 2 Aug 2022 10:01:58 -0500 [thread overview]
Message-ID: <c82114b6-1003-bfb5-0550-98dcbf1a3761@lwfinger.net> (raw)
In-Reply-To: <Yukx8KEEOhKTJ7HQ@nx64de-df6d00>
On 8/2/22 09:17, Grzegorz Szymaszek wrote:
> On Tue, Aug 02, 2022 at 04:07:25PM +0200, Greg KH wrote:
>> Looks like someone needs to add a line to the driver that looks like:
>> MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
>> […] Can you make a patch that does this?
>
> Sure, I will prepare and send one later (hopefully today), assuming no
> one objects in the meantime. Thanks for quick response.
There will be no objections. All 8188eu-based devices need that firmware.
Omitting the MODULE_FIRMWARE macro was simply an oversight.
Larry
next prev parent reply other threads:[~2022-08-02 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 13:17 The r8188eu kernel module does not depend on the rtlwifi/rtl8188eufw.bin firmware file Grzegorz Szymaszek
2022-08-02 14:07 ` Greg KH
2022-08-02 14:17 ` Grzegorz Szymaszek
2022-08-02 15:01 ` Larry Finger [this message]
2022-08-02 17:18 ` [PATCH] staging: r8188eu: add firmware dependency Grzegorz Szymaszek
2022-08-02 18:03 ` Larry Finger
2022-08-02 19:02 ` Phillip Potter
2022-08-03 6:08 ` Greg KH
2022-08-03 6:33 ` Grzegorz Szymaszek
2022-08-03 6:37 ` Greg KH
2022-08-03 22:28 ` [PATCH 1/3] staging: r8188eu: set firmware path in a macro Grzegorz Szymaszek
2022-08-03 22:29 ` [PATCH 2/3] staging: r8188eu: make use of the DRV_NAME macro Grzegorz Szymaszek
2022-08-05 6:40 ` Greg KH
2022-08-03 22:29 ` [PATCH 3/3] staging: r8188eu: make driver metadata macro names more consistent Grzegorz Szymaszek
2022-08-05 6:39 ` Greg KH
2022-08-04 20:11 ` [PATCH 1/3] staging: r8188eu: set firmware path in a macro Philipp Hortmann
2022-08-04 22:23 ` Grzegorz Szymaszek
2022-08-05 4:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c82114b6-1003-bfb5-0550-98dcbf1a3761@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=greg@kroah.com \
--cc=gszymaszek@short.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).