From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] tpm: add support for partial reads
Date: Mon, 19 Nov 2018 09:43:00 -0800 [thread overview]
Message-ID: <c821b1f3-0c6d-bb52-c2af-d5c0fdc5b468@intel.com> (raw)
In-Reply-To: <20181119172824.GB16252@linux.intel.com>
On 11/19/18 9:28 AM, Jarkko Sakkinen wrote:
> Ah, you are correct.
>
> You should add a boolean flag instead of introducing a new variable for
> holding amount that has been read because obviously one read operation
> is enough for backwards compatibility.
>
> The code could read the code to data_pending and then set
>
> priv->data_read = false;
>
> We do not need the original amount for anything.
but we still need to keep track of how much of the response is left unconsumed.
--
Tadeusz
next prev parent reply other threads:[~2018-11-19 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 17:51 [PATCH 1/2] tpm: rename data_pending to transmit_result Tadeusz Struk
2018-11-16 17:51 ` [PATCH v4 2/2] tpm: add support for partial reads Tadeusz Struk
2018-11-18 7:48 ` Jarkko Sakkinen
2018-11-19 3:05 ` Tadeusz Struk
2018-11-19 13:58 ` Jarkko Sakkinen
2018-11-19 16:44 ` Tadeusz Struk
2018-11-19 17:28 ` Jarkko Sakkinen
2018-11-19 17:43 ` Tadeusz Struk [this message]
2018-11-18 7:41 ` [PATCH 1/2] tpm: rename data_pending to transmit_result Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c821b1f3-0c6d-bb52-c2af-d5c0fdc5b468@intel.com \
--to=tadeusz.struk@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).