linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Weiß" <michael.weiss@aisec.fraunhofer.de>
To: Thomas Gleixner <tglx@linutronix.de>,
	Andrei Vagin <avagin@gmail.com>,
	Christian Brauner <christian.brauner@ubuntu.com>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	"J . Bruce Fields" <bfields@fieldses.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v4 2/3] fs/proc: apply the time namespace offset to /proc/stat btime
Date: Tue, 27 Oct 2020 12:56:34 +0100	[thread overview]
Message-ID: <c83b8551-ebb9-12df-3e3b-fcd4047671bd@aisec.fraunhofer.de> (raw)
In-Reply-To: <87eell46y2.fsf@nanos.tec.linutronix.de>

Thomas,

On 26.10.20 11:28, Thomas Gleixner wrote:
> On Mon, Oct 19 2020 at 21:52, Michael Weiß wrote:
> 
>> '/proc/stat' provides the field 'btime' which states the time stamp of
>> system boot in seconds. In case of time namespaces, the offset to the
>> boot time stamp was not applied earlier. However, in container
>> runtimes which utilize time namespaces to virtualize boottime of a
>> container, this leaks information about the host system boot time.
> 
> Not sure if that qualifies as a leak. The point is that it confuses the
> tasks which are in a different time universe.
> 
From a container isolation perspective this could be interpreted as an
information leak, if you want to hide the host systems boot time form
users inside of the container.
However, since proc is not totally isolated concerning host system
information inside of namespaces, I agree to your point.

I will take this into account when preparing v5.
When amending the tags I will also updated this passage and remove the
leak statement.

Thanks,
Michael

  reply	other threads:[~2020-10-27 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 19:52 [PATCH v4 0/3] time namespace aware system boot time Michael Weiß
2020-10-19 19:52 ` [PATCH v4 1/3] timens: additional helper functions for boottime offset handling Michael Weiß
2020-10-19 19:52 ` [PATCH v4 2/3] fs/proc: apply the time namespace offset to /proc/stat btime Michael Weiß
2020-10-26 10:28   ` Thomas Gleixner
2020-10-27 11:56     ` Michael Weiß [this message]
2020-10-19 19:52 ` [PATCH v4 3/3] selftests/timens: added selftest for " Michael Weiß
2020-10-22  8:36 ` [PATCH v4 0/3] time namespace aware system boot time Andrei Vagin
2020-10-26 10:27 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c83b8551-ebb9-12df-3e3b-fcd4047671bd@aisec.fraunhofer.de \
    --to=michael.weiss@aisec.fraunhofer.de \
    --cc=0x7f454c46@gmail.com \
    --cc=anna.schumaker@netapp.com \
    --cc=avagin@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).