From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AC8C54E94 for ; Thu, 26 Jan 2023 15:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbjAZPmQ (ORCPT ); Thu, 26 Jan 2023 10:42:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbjAZPmO (ORCPT ); Thu, 26 Jan 2023 10:42:14 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C026DFEA for ; Thu, 26 Jan 2023 07:41:50 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so3514830wmb.0 for ; Thu, 26 Jan 2023 07:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k0m12v3Di2o/+lIlzBAfogul/kt+ur4S1vNxsmILAGw=; b=n/tt0TbbZY0kvvmlybh+maDKHQ0be4D7R2GJKVsJPSnJpVsx0QLfpqZZqdY0GvK2Rj CDDH1MgMpvljpXQpOQZODWUXYojOW/ygyBIW5eLeOqR1t9yhYV+UpJOGKnrxpH79FpYD eJUQKgSM2oK309E6IXdbCCYlwwu47qgl0ob6zmebhg1Z83DhVXlVoVW/hpmT7LfqDHE+ s1Rk5q26JwDcJ8vYdVxuro2CG1Mt/rFiV2Nu9V1CsS0NBtql8GlWwAnH5ypNl22MJpQw VfcF+NcQqSMFhL0zzCieU4CVxSqFYgaIHpNiOHdy6QcMZlzupyeVoYkDihkeDxmUT/Pb cqBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k0m12v3Di2o/+lIlzBAfogul/kt+ur4S1vNxsmILAGw=; b=M9Ql48TrGmErcrogvhPbZNS2slD0D0lvsrpirZlV5t41V88TLV8oXlZsWTY1PGi72W eS8eAZXwBgByvkk8C+G63q4R8xLm+nL+AJIr2xx/OyzqmnW/Mr+OOH5VVNZDqu2S5KqW wDadOBvY8O0j4imfmEnXm6eU12TjpSwBJUfd+DQQ3AZCaqxBwwcT4SMrQ9YLXnnwuFtc k/lRYDLnc73H7+YDYNkMtAemZw76XnU5MNbXxIvZ3+EagcNFpvggR/iML1cr6A1NP/LN ifujVxFNKh/pVY1iNs1em2vx8vhImI21qrMqUmdINNQ17iyqm+diRenYUm723V52kluG cjfw== X-Gm-Message-State: AFqh2kqsTD/knWtoeawfmVDS54nUrXXxPeH7E1R/2qlq0hPlqIlm29uP NhDHRNlqnuBzO9oamOHH8uiL3w== X-Google-Smtp-Source: AMrXdXuOVMWTSO6PYETKl64COGKG0SdwZcv6kBqbetqGCuLNBWyPlhLiAo0Ppr7eUnXdj8jthAjXvA== X-Received: by 2002:a05:600c:4a27:b0:3da:fae5:7e2f with SMTP id c39-20020a05600c4a2700b003dafae57e2fmr35805078wmp.3.1674747709376; Thu, 26 Jan 2023 07:41:49 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j38-20020a05600c1c2600b003daff80f16esm7367238wms.27.2023.01.26.07.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 07:41:48 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 16:41:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface Content-Language: en-US To: Jonathan Cormier , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Williamson , Bob Duke References: <20230125-tfp410_i2c-v1-0-66a4d4e390b7@criticallink.com> <20230125-tfp410_i2c-v1-2-66a4d4e390b7@criticallink.com> From: Krzysztof Kozlowski In-Reply-To: <20230125-tfp410_i2c-v1-2-66a4d4e390b7@criticallink.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2023 22:09, Jonathan Cormier wrote: > From: Michael Williamson > > The TFP410 driver does not support I2C. As such, the device remains in > Power Down if the I2C is enabled by the bootstrap pins. > > Add basic support for the I2C interface, and provide support to take > the device out of power down when enabled. Also read the bootstrap mode > pins via the CTL_1_MODE register when using the I2C bus. > > Signed-off-by: Michael Williamson > Signed-off-by: Jonathan Cormier > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 95 +++++++++++++++++++++++++++----------- > 1 file changed, 68 insertions(+), 27 deletions(-) Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). hint: it is entirely different. > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index b9635abbad16..323a6d9ed188 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -21,6 +22,20 @@ (...) > > static void tfp410_i2c_remove(struct i2c_client *client) > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids); > static struct i2c_driver tfp410_i2c_driver = { > .driver = { > .name = "tfp410", > - .of_match_table = of_match_ptr(tfp410_match), > + .of_match_table = tfp410_match, This does not look related to the patch. Best regards, Krzysztof