From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5A7C433EF for ; Thu, 23 Sep 2021 12:08:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2381C610C9 for ; Thu, 23 Sep 2021 12:08:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240799AbhIWMJm (ORCPT ); Thu, 23 Sep 2021 08:09:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54679 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240713AbhIWMJk (ORCPT ); Thu, 23 Sep 2021 08:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632398889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfX6IYx3+cjotqqgeU3GLgEgUJixfrJO00QEhWanizg=; b=EqChbtiSxedZbLcGdvtAbgNOcGSPkY8qRIWz7Z0QFaAcKYOCM4pdtKQt29vqojoOGa2Htz 7EMMlViKfmc2GKnvBYRXXRRJ+YmBhzJUuUofYTIDcY5AiPdxCP3hPjTn0srBN3ofxsH9wH TMGuoTPOnghpyyA4fDj/1c90GuPPqhc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-kaIgNQRXNEm7y1cMmWKwZA-1; Thu, 23 Sep 2021 08:08:07 -0400 X-MC-Unique: kaIgNQRXNEm7y1cMmWKwZA-1 Received: by mail-lf1-f72.google.com with SMTP id m2-20020ac24ac2000000b003f524eae63eso5909386lfp.10 for ; Thu, 23 Sep 2021 05:08:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:cc:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wfX6IYx3+cjotqqgeU3GLgEgUJixfrJO00QEhWanizg=; b=fwHZ9Fm82wNF8HHRhrWVyMw/qAKPzB6hcXcHB2H0sCBx8Rb2ONZonb0ordv4DFzXQc BekYLR6pE6Rn+vj2M7ZtqShOqZAa2FztAubpWsSa3BzwpJv4U9KPNIHBCkVBWpr1Eva5 5seYlFB/TRy80MSfl1gcaWK5BasWDwAoW0Uj2gaDQu85wCA/fU30VaQM0meuTmIDFhQS fu8Tv0ZpELJ9sPXo5gP7stON6NEgn/nAKRAhYY5yqtg+Z3FOogFjia57kTT6/I8s5WVI /sFoAvuzg0X0KN8bcLYnqLac7kHha5wQxV7ZNFrkyU3Rf5ZSiAy1K3a+v8oEXtpRnutn qAyA== X-Gm-Message-State: AOAM532wsQljdPM09AcQ+VmYtetVZlOWjSQFT7tjg8E/NrKPk8J87t0V SKXyBJ24QPtlFWXHF77b2Q1A6FW5oWlyOPn6BLpB9p82KuBDNZFEpB0OpPWgS3rdBT0xd8VgMU9 SI+oks5YWtzxDoXMVrEEdlcKH X-Received: by 2002:a2e:584:: with SMTP id 126mr491206ljf.126.1632398886326; Thu, 23 Sep 2021 05:08:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvHZO4Tckj6DIt294JJG00bnWYHQJ7x4NbhTMU8P1fLHefb48FQBjkpuhOQ9xDF6sE59tRXg== X-Received: by 2002:a2e:584:: with SMTP id 126mr491169ljf.126.1632398886131; Thu, 23 Sep 2021 05:08:06 -0700 (PDT) Received: from [192.168.42.238] (87-59-106-155-cable.dk.customer.tdc.net. [87.59.106.155]) by smtp.gmail.com with ESMTPSA id l9sm213486ljg.44.2021.09.23.05.08.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 05:08:05 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org, hawk@kernel.org, ilias.apalodimas@linaro.org, jonathan.lemon@gmail.com, alobakin@pm.me, willemb@google.com, cong.wang@bytedance.com, pabeni@redhat.com, haokexin@gmail.com, nogikh@google.com, elver@google.com, memxor@gmail.com, edumazet@google.com, alexander.duyck@gmail.com, dsahern@gmail.com Subject: Re: [PATCH net-next 2/7] page_pool: support non-split page with PP_FLAG_PAGE_FRAG To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org References: <20210922094131.15625-1-linyunsheng@huawei.com> <20210922094131.15625-3-linyunsheng@huawei.com> Message-ID: Date: Thu, 23 Sep 2021 14:08:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922094131.15625-3-linyunsheng@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2021 11.41, Yunsheng Lin wrote: > Currently when PP_FLAG_PAGE_FRAG is set, the caller is not > expected to call page_pool_alloc_pages() directly because of > the PP_FLAG_PAGE_FRAG checking in __page_pool_put_page(). > > The patch removes the above checking to enable non-split page > support when PP_FLAG_PAGE_FRAG is set. > > Reviewed-by: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > net/core/page_pool.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index a65bd7972e37..f7e71dcb6a2e 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -315,11 +315,14 @@ struct page *page_pool_alloc_pages(struct page_pool *pool, gfp_t gfp) > > /* Fast-path: Get a page from cache */ > page = __page_pool_get_cached(pool); > - if (page) > - return page; > > /* Slow-path: cache empty, do real allocation */ > - page = __page_pool_alloc_pages_slow(pool, gfp); > + if (!page) > + page = __page_pool_alloc_pages_slow(pool, gfp); > + > + if (likely(page)) > + page_pool_set_frag_count(page, 1); > + I really don't like that you add one atomic_long_set operation per page alloc call. This is a fast-path for XDP use-cases, which you are ignoring as you drivers doesn't implement XDP. As I cannot ask you to run XDP benchmarks, I fortunately have some page_pool specific microbenchmarks you can run instead. I will ask you to provide before and after results from running these benchmarks [1] and [2]. [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c [2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_cross_cpu.c How to use these module is documented here[3]: [3] https://prototype-kernel.readthedocs.io/en/latest/prototype-kernel/build-process.html > return page; > } > EXPORT_SYMBOL(page_pool_alloc_pages); > @@ -428,8 +431,7 @@ __page_pool_put_page(struct page_pool *pool, struct page *page, > unsigned int dma_sync_size, bool allow_direct) > { > /* It is not the last user for the page frag case */ > - if (pool->p.flags & PP_FLAG_PAGE_FRAG && > - page_pool_atomic_sub_frag_count_return(page, 1)) > + if (page_pool_atomic_sub_frag_count_return(page, 1)) > return NULL; This adds an atomic_long_read, even when PP_FLAG_PAGE_FRAG is not set. > > /* This allocator is optimized for the XDP mode that uses >