From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdASI4l (ORCPT ); Thu, 19 Jan 2017 03:56:41 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:39657 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdASI4j (ORCPT ); Thu, 19 Jan 2017 03:56:39 -0500 Subject: Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table To: Johannes Thumshirn References: <1484757173-235951-1-git-send-email-john.garry@huawei.com> <1484757173-235951-3-git-send-email-john.garry@huawei.com> <20170119084337.GF5054@linux-x5ow.site> CC: , , , , , , , , Xiang Chen From: John Garry Message-ID: Date: Thu, 19 Jan 2017 08:55:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170119084337.GF5054@linux-x5ow.site> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.86] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.58807F2C.00CF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c12b9882389a231373f25d6f6a56e373 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/2017 08:44, Johannes Thumshirn wrote: > On Thu, Jan 19, 2017 at 12:32:48AM +0800, John Garry wrote: >> From: Xiang Chen >> >> Set SMP connection timeout and continue AWT timer; >> Clear ITCT table when dev gone. >> >> Signed-off-by: Xiang Chen >> Signed-off-by: John Garry >> --- >> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c >> index 6c787eb..452e329 100644 >> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c >> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c >> @@ -334,6 +334,8 @@ >> #define ITCT_HDR_MCR_MSK (0xf << ITCT_HDR_MCR_OFF) >> #define ITCT_HDR_VLN_OFF 9 >> #define ITCT_HDR_VLN_MSK (0xf << ITCT_HDR_VLN_OFF) >> +#define ITCT_HDR_SMP_TIMEOUT_OFF 16 >> +#define ITCT_HDR_AWT_CONTINUE_OFF 25 >> #define ITCT_HDR_PORT_ID_OFF 28 >> #define ITCT_HDR_PORT_ID_MSK (0xf << ITCT_HDR_PORT_ID_OFF) >> /* qw2 */ >> @@ -696,6 +698,8 @@ static void setup_itct_v2_hw(struct hisi_hba *hisi_hba, >> qw0 |= ((1 << ITCT_HDR_VALID_OFF) | >> (device->linkrate << ITCT_HDR_MCR_OFF) | >> (1 << ITCT_HDR_VLN_OFF) | >> + (0xfa << ITCT_HDR_SMP_TIMEOUT_OFF) | > ^~ You may want to give that magic value a name. > Thanks for having a look. We will create a new patch without the mysterious value. Regards, John > Other than that, > Reviewed-by: Johannes Thumshirn >