linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <Nicolas.Ferre@microchip.com>, <linux@armlinux.org.uk>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>
Cc: <Eugen.Hristev@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<sfr@canb.auug.org.au>
Subject: Re: [PATCH 1/2] ARM: at91: fix link error
Date: Mon, 19 Jul 2021 13:17:34 +0000	[thread overview]
Message-ID: <c8748c61-eb7b-4d1c-a770-b7f684fa9096@microchip.com> (raw)
In-Reply-To: <9f5f6c1b-835c-46ae-6466-70aaafccd6e9@microchip.com>

On 19.07.2021 15:40, Nicolas Ferre wrote:
> Hi Claudiu,
> 
> On 19/07/2021 at 10:03, Claudiu Beznea wrote:
>> PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
>> soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
>> that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
>> Kconfig thus the link error bellow:
>>
>> arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
>> sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
>> make: *** [Makefile:1176: vmlinux] Error 1
>>
>> Add proper flags to AT91 Kconfig file to solve the issue.
>>
>> Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
>> Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5")
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>   arch/arm/mach-at91/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
>> index f52b46bccd85..b09bb2279f7f 100644
>> --- a/arch/arm/mach-at91/Kconfig
>> +++ b/arch/arm/mach-at91/Kconfig
>> @@ -204,6 +204,9 @@ config ATMEL_PM
>>   config SOC_SAMA7
>>       bool
>>       select ARM_GIC
>> +    select ATMEL_PM if PM
>> +    select ATMEL_SDRAMC
>>       select MEMORY
>>       select SOC_SAM_V7
>> +    select SRAM if PM
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> I squashed this patch in 18d694ecd91e ("ARM: at91: add new SoC sama7g5"),
> verified that it compiles and rebased the at91-soc branch on it. The commit
> message is as follow (wrapped):
> 
> ARM: at91: add new SoC sama7g5
> 
> Add new SoC from at91 family : sama7g5
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> [claudiu.beznea@microchip.com: Select PLL, generic clock and UTMI support,
> add PM configs]
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Link:
> https://lore.kernel.org/r/20210409113116.482199-1-eugen.hristev@microchip.com
> Link:
> https://lore.kernel.org/r/20210719080317.1045832-2-claudiu.beznea@microchip.com
> 
> 
> Added lore link will allow us to trace this part of the discussion.
> Here is the new branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git/log/?h=at91-soc
> 
> Tell me if it's good for you.

Hi Nicolas,

It's good for me.

Thank you,
Claudiu

> 
> Thanks for having fixed that so quickly. Best regards,
>   Nicolas
> 
> 


  reply	other threads:[~2021-07-19 13:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  8:03 [PATCH 0/2] ARM: at91: fix compilation errors after SAMA7G5 Claudiu Beznea
2021-07-19  8:03 ` [PATCH 1/2] ARM: at91: fix link error Claudiu Beznea
2021-07-19 12:40   ` Nicolas Ferre
2021-07-19 13:17     ` Claudiu.Beznea [this message]
2021-07-19  8:03 ` [PATCH 2/2] clk: at91: add register definition for sama7g5's master clock Claudiu Beznea
2021-07-19 12:46   ` Nicolas Ferre
2021-07-27  1:19     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8748c61-eb7b-4d1c-a770-b7f684fa9096@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: [PATCH 1/2] ARM: at91: fix link error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).