From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756176AbdKDBBE (ORCPT ); Fri, 3 Nov 2017 21:01:04 -0400 Received: from qproxy2-pub.mail.unifiedlayer.com ([69.89.16.161]:56607 "EHLO qproxy2.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751955AbdKDBBC (ORCPT ); Fri, 3 Nov 2017 21:01:02 -0400 X-Greylist: delayed 1276 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 Nov 2017 21:01:02 EDT X-Authority-Analysis: v=2.2 cv=JNNLi4Cb c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=EA5itrwUPoEA:10 a=IkcTkHD0fZMA:10 a=sC3jslCIGhcA:10 a=09pZa1zuONQFN_fXOPwA:9 a=QEXdDO2ut3YA:10 Subject: Re: [PATCH] block/aoe: discover_timer: Convert timers to use timer_setup() To: Kees Cook , Jens Axboe Cc: Thomas Gleixner , linux-kernel@vger.kernel.org References: <20171102233151.GA103378@beast> From: Ed Cashin Message-ID: Date: Fri, 3 Nov 2017 20:39:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102233151.GA103378@beast> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box320.bluehost.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - acm.org X-BWhitelist: no X-Source-IP: 24.99.197.19 X-Exim-ID: 1eAmUw-00088a-Mp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-24-99-197-19.hsd1.ga.comcast.net ([10.0.0.86]) [24.99.197.19]:43436 X-Source-Auth: ed@cashinworks.com X-Email-Count: 4 X-Source-Cap: Y2FzaGlud287Y2FzaGlud287Ym94MzIwLmJsdWVob3N0LmNvbQ== X-Local-Domain: no Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 07:31 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > This refactors the discover_timer to remove the needless locking and > state machine used for synchronizing timer death. Using del_timer_sync() > will already do the right thing. Looks OK to me, thanks. -- Ed