Re: [PATCH 6/7] ASoC: dt-bindings: mediatek,mt79xx-wm8960: add mt79xx-wm8960 document

From: "Maso Huang (黃加竹)" <Maso.Huang@mediatek.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>,
	"renzhijie2@huawei.com" <renzhijie2@huawei.com>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"perex@perex.cz" <perex@perex.cz>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"Jiaxin Yu (俞家鑫)" <Jiaxin.Yu@mediatek.com>
Subject: Re: [PATCH 6/7] ASoC: dt-bindings: mediatek,mt79xx-wm8960: add mt79xx-wm8960 document
Date: Wed, 14 Jun 2023 07:40:56 +0000	[thread overview]
Message-ID: <c87eadd9fc8d0ef9dc4582493e540f0b311e06eb.camel@mediatek.com> (raw)
In-Reply-To: <7bf1395a-eba8-fe27-a359-9c50af7add2a@kernel.org>

On Tue, 2023-06-13 at 10:49 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 12/06/2023 12:52, Maso Hunag wrote:
> > From: Maso Huang <maso.huang@mediatek.com>
> > 
> > Add document for mt79xx board with wm8960.
> 
> Please use scripts/get_maintainers.pl to get a list of necessary
> people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you
> base
> your patches on recent Linux kernel.
> 

Hi Krzysztof,
I'll add necessary maintainers back in v2 patch.

> > 
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> > ---
> >  .../sound/mediatek,mt79xx-wm8960.yaml         | 53
> +++++++++++++++++++
> >  1 file changed, 53 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml
> > 
> > diff --git
> a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml 
> b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml
> > new file mode 100644
> > index 000000000000..26b38bb629da
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-
> wm8960.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek MT79xx ASOC sound card with WM8960 codec
> 
> What is a MT79xx ASOC? Is it some specific SoC name? What does "A"
> stands for in SoC? XX also looks odd, I thought Mediatek uses only
> numbers.
> 

I'll use mt7986 instead of mt79xx in v2 patch.
And ASoC means ALSA SoC.

> > +
> > +maintainers:
> > +  - Maso Huang <maso.huang@mediatek.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt79xx-wm8960-machine
> > +
> > +  mediatek,platform:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: The phandle of MT79xx ASoC platform.
> 
> What is MT79xx ASoC platform?
> 

I'll use mt7986 instead of mt79xx in v2 patch.
> 
> 
> Best regards,
> Krzysztof
> 

Best regards,
Maso