From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F56EC433EF for ; Tue, 7 Jun 2022 14:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235524AbiFGOfx (ORCPT ); Tue, 7 Jun 2022 10:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235493AbiFGOfu (ORCPT ); Tue, 7 Jun 2022 10:35:50 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6420C647E; Tue, 7 Jun 2022 07:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654612549; x=1686148549; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=Rcg+NasEe8/3X7t7oVPT1nlH+/sLl3ybJIeFpVDXsK8=; b=gzCRyy/nTscfYFZo+hsgLm0YpElwr5l9/ZLgRdpLF7UjJ9dyNBYuPK9E QMhuRDjyW611TS2Jy85kKMsIzahZBCf343SPpN+4+m8Hvo7ljG5A7lVz3 62Dk43L0Bln9XENPHGS3F9KESYR4eBLlBQ6LQOmjB+xFHG+glvrC8TEXW SMlmMJjqwsAUh+SYkWveycLA+7cLtQodUhoyc/7+aSCFjc6ZOEFAZJAZ6 jzowXniapVyQ9FDEJDweG5B65HqYl4ajOCh65hFy6HUyWXm9eoGa4Aiw0 jkK9Kx/8Sawhi+geRX/GCAtVUvpKfn3PKDHPFyOpBXvg+H3jQGPqsB64y g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="277543282" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="277543282" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 07:30:25 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="636147593" Received: from akmessan-mobl1.amr.corp.intel.com ([10.251.214.146]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 07:30:23 -0700 Date: Tue, 7 Jun 2022 17:30:21 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jiri Slaby cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/36] tty/vt: consolemap: extract dict unsharing to con_unshare_unimap() In-Reply-To: <20220607104946.18710-19-jslaby@suse.cz> Message-ID: References: <20220607104946.18710-1-jslaby@suse.cz> <20220607104946.18710-19-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1491044709-1654612224=:1622" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1491044709-1654612224=:1622 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 7 Jun 2022, Jiri Slaby wrote: > The code in con_set_unimap() is too nested. Extract its obvious part > into a separate function and name it after what the code does: > con_unshare_unimap(). > > Signed-off-by: Jiri Slaby Reviewed-by: Ilpo Järvinen -- i. --8323329-1491044709-1654612224=:1622--