linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Fabian Schindlatz <fabian.schindlatz@fau.de>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Thomas Röthenbacher" <thomas.roethenbacher@fau.de>,
	linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH] bluetooth: Cleanup formatting and coding style
Date: Sun, 23 Jun 2019 14:56:33 -0700	[thread overview]
Message-ID: <c88cfce8a80eb69c932fd249f2ef0224e60b127a.camel@perches.com> (raw)
In-Reply-To: <20190623211548.1966-1-fabian.schindlatz@fau.de>

On Sun, 2019-06-23 at 23:15 +0200, Fabian Schindlatz wrote:
> Fix some warnings and one error reported by checkpatch.pl:
[]
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
[]
> @@ -351,7 +356,8 @@ static int ll_enqueue(struct hci_uart *hu, struct sk_buff *skb)
>  		skb_queue_tail(&ll->tx_wait_q, skb);
>  		break;
>  	default:
> -		BT_ERR("illegal hcill state: %ld (losing packet)", ll->hcill_state);
> +		BT_ERR("illegal hcill state: %ld (losing packet)",

trivia:

Might use invalid instead of illegal as no crime was committed.



  reply	other threads:[~2019-06-24  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-23 21:15 [PATCH] bluetooth: Cleanup formatting and coding style Fabian Schindlatz
2019-06-23 21:56 ` Joe Perches [this message]
2019-07-06 10:51 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c88cfce8a80eb69c932fd249f2ef0224e60b127a.camel@perches.com \
    --to=joe@perches.com \
    --cc=fabian.schindlatz@fau.de \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=thomas.roethenbacher@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).