From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Abhishek Sahu <absahu@codeaurora.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
"Imran Shaik" <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>
Subject: Re: [PATCH 4/5] clk: qcom: Add camera clock controller driver for SM8150
Date: Fri, 8 Mar 2024 18:10:13 +0530 [thread overview]
Message-ID: <c892f773-7716-4736-3499-5c8254e3618e@quicinc.com> (raw)
In-Reply-To: <35a7ad40-aaf4-476e-8582-b83bac284881@linaro.org>
On 3/8/2024 4:29 PM, Bryan O'Donoghue wrote:
> On 08/03/2024 10:58, Bryan O'Donoghue wrote:
>> On 08/03/2024 10:46, Satya Priya Kakitapalli (Temp) wrote:
>>>>
>>>> Not if you mark it critical
>>>>
>>>
>>> Marking the clock as critical keeps the associated power domain
>>> always-on which impacts power. For this reason we are not using
>>> CLK_IS_CRITICAL and instead making them always on from probe.
>>
>> How does the clock do anything _useful_ if the power-domain gets
>> switched off ?
>>
>> ---
>> bod
>
> i.e. the clock can't be running "always-on" if it has no power..
>
If BIT(0) is set from probe, during any active usecase, the clock gets
turned ON automatically when the power domain is turned ON.
But when we use CLK_IS_CRITICAL flag, the framework keeps the power
domain ON and doesn't let the power domain to turn off even when there
is no active usecase.
next prev parent reply other threads:[~2024-03-08 12:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 5:38 [PATCH 0/5] clk: qcom: sm8150: Add camera clock controller support for SM8150 Satya Priya Kakitapalli
2024-02-29 5:38 ` [PATCH 1/5] clk: qcom: alpha-pll: Fix the pll post div mask Satya Priya Kakitapalli
2024-03-01 23:48 ` Konrad Dybcio
2024-02-29 5:38 ` [PATCH 2/5] clk: qcom: clk-alpha-pll: Add support for Regera PLL ops Satya Priya Kakitapalli
2024-03-01 23:56 ` Konrad Dybcio
2024-03-08 8:26 ` Satya Priya Kakitapalli (Temp)
2024-03-13 18:43 ` Konrad Dybcio
2024-02-29 5:38 ` [PATCH 3/5] dt-bindings: clock: qcom: Add SM8150 camera clock controller Satya Priya Kakitapalli
2024-02-29 8:00 ` Krzysztof Kozlowski
2024-02-29 5:38 ` [PATCH 4/5] clk: qcom: Add camera clock controller driver for SM8150 Satya Priya Kakitapalli
2024-03-02 16:13 ` Bryan O'Donoghue
2024-03-06 8:30 ` Satya Priya Kakitapalli (Temp)
2024-03-06 13:55 ` Bryan O'Donoghue
2024-03-08 10:46 ` Satya Priya Kakitapalli (Temp)
2024-03-08 10:58 ` Bryan O'Donoghue
2024-03-08 10:59 ` Bryan O'Donoghue
2024-03-08 12:40 ` Satya Priya Kakitapalli (Temp) [this message]
2024-03-08 13:04 ` Bryan O'Donoghue
2024-03-08 11:54 ` Dmitry Baryshkov
2024-03-28 9:42 ` Satya Priya Kakitapalli (Temp)
2024-04-05 6:27 ` Satya Priya Kakitapalli (Temp)
2024-04-05 21:32 ` Stephen Boyd
2024-02-29 5:38 ` [PATCH 5/5] arm64: dts: qcom: Add camera clock controller for sm8150 Satya Priya Kakitapalli
2024-03-02 16:15 ` Bryan O'Donoghue
2024-03-06 8:32 ` Satya Priya Kakitapalli (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c892f773-7716-4736-3499-5c8254e3618e@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=absahu@codeaurora.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).