From: Mikko Perttunen <mperttunen@nvidia.com>
To: Corentin Labbe <clabbe@baylibre.com>, <hdegoede@redhat.com>,
<tj@kernel.org>, <sfr@canb.auug.org.au>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"
Date: Tue, 17 Jul 2018 13:57:15 +0300 [thread overview]
Message-ID: <c8a963fa-70c8-ea79-3c30-69bf723fb764@nvidia.com> (raw)
In-Reply-To: <1531824575-852-1-git-send-email-clabbe@baylibre.com>
Thanks!
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
On 17.07.2018 13:49, Corentin Labbe wrote:
> Since ahci_platform_put_resources() use target_pwrs after "devm_" freed
> it, we cannot use devm_kcalloc for allocating target_pwrs.
>
> This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85.
>
> Reported-by: Mikko Perttunen <mperttunen@nvidia.com>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/ata/libahci_platform.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index fe8939e161ea..2ceebaf2ed56 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -271,6 +271,8 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
> for (c = 0; c < hpriv->nports; c++)
> if (hpriv->target_pwrs && hpriv->target_pwrs[c])
> regulator_put(hpriv->target_pwrs[c]);
> +
> + kfree(hpriv->target_pwrs);
> }
>
> static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
> @@ -406,7 +408,11 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
> rc = -ENOMEM;
> goto err_out;
> }
> - hpriv->target_pwrs = devm_kcalloc(dev, hpriv->nports, sizeof(*hpriv->target_pwrs), GFP_KERNEL);
> + /*
> + * We cannot use devm_ here, since ahci_platform_put_resources() uses
> + * target_pwrs after devm_ have freed memory
> + */
> + hpriv->target_pwrs = kcalloc(hpriv->nports, sizeof(*hpriv->target_pwrs), GFP_KERNEL);
> if (!hpriv->target_pwrs) {
> rc = -ENOMEM;
> goto err_out;
>
next prev parent reply other threads:[~2018-07-17 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:49 [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc" Corentin Labbe
2018-07-17 10:57 ` Mikko Perttunen [this message]
2018-07-18 6:30 ` Marcel Ziswiler
2018-07-24 15:22 ` Jon Hunter
2018-07-24 16:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a963fa-70c8-ea79-3c30-69bf723fb764@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=clabbe@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).