>From 8368d1b6404d63da7d502f6cd2ce6b50c7ffa9b9 Mon Sep 17 00:00:00 2001 From: Aviya Erenfeld Date: Tue, 21 Mar 2017 00:07:19 +0200 Subject: [PATCH] staging: goldfish: Fix coding style issues Fix the coding style issues that raised by checkpatch.pl in that driver. (For the eudyptula challenge) Signed-off-by: Aviya Erenfeld --- drivers/staging/goldfish/goldfish_audio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index bd55995..f1640ab 100644 --- a/drivers/staging/goldfish/goldfish_audio.c +++ b/drivers/staging/goldfish/goldfish_audio.c @@ -61,10 +61,12 @@ struct goldfish_audio { #define COMBINED_BUFFER_SIZE ((2 * READ_BUFFER_SIZE) + \ (2 * WRITE_BUFFER_SIZE)) -#define AUDIO_READ(data, addr) (readl(data->reg_base + addr)) -#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr)) +#define AUDIO_READ(data, addr) (readl((data)->reg_base + (addr))) +#define AUDIO_WRITE(data, addr, x) (writel(x, (data)->reg_base + (addr))) #define AUDIO_WRITE64(data, addr, addr2, x) \ - (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2)) + ({typeof(data) _data = (data); \ + gf_write_dma_addr((x), _data->reg_base + (addr), \ + _data->reg_base + (addr2)); }) /* * temporary variable used between goldfish_audio_probe() and -- 2.7.4