From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode'
Date: Thu, 14 May 2020 09:32:40 +0800 [thread overview]
Message-ID: <c8b781aa-da2b-5aa7-aadc-a1980c84bd0d@huawei.com> (raw)
In-Reply-To: <CAAEAJfAzcRTLE3HWHJqWvuENYnPCU-E6TdaDWXc+WNHOaUqdyA@mail.gmail.com>
Hi Ezequiel,
Thanks for your reply !
On 2020/5/14 3:32, Ezequiel Garcia wrote:
> On Mon, 11 May 2020 at 05:49, Xiongfeng Wang <wangxiongfeng2@huawei.com> wrote:
>>
>> When I cat module parameter 'dma_mode' by sysfs, it displays as follows.
>> It is better to add a newline for easy reading.
>>
>> [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode
>> memcpy[root@hulk-202 ~]#
>>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>
> I don't mind this change, but I don't think this is standard.
> The lack of newline follows what other drivers are doing.
>
> # hexdump -c /sys/module/acpi/parameters/ec_event_clearing
> 0000000 q u e r y
> 0000005
>
> Is it really an issue for you?
It's not an issue for me. It's just that if the result is in a separate line, it
reads more easily. I am also planning to fix the parameters below
'/sys/module/acpi/parameters'.
Thanks,
Xiongfeng
>
> Thanks,
> Ezequiel
>
>> ---
>> drivers/media/pci/tw686x/tw686x-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c
>> index 74ae4f0..bfc61da 100644
>> --- a/drivers/media/pci/tw686x/tw686x-core.c
>> +++ b/drivers/media/pci/tw686x/tw686x-core.c
>> @@ -71,7 +71,7 @@ static const char *dma_mode_name(unsigned int mode)
>>
>> static int tw686x_dma_mode_get(char *buffer, const struct kernel_param *kp)
>> {
>> - return sprintf(buffer, "%s", dma_mode_name(dma_mode));
>> + return sprintf(buffer, "%s\n", dma_mode_name(dma_mode));
>> }
>>
>> static int tw686x_dma_mode_set(const char *val, const struct kernel_param *kp)
>> --
>> 1.7.12.4
>>
>
next prev parent reply other threads:[~2020-05-14 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 8:43 [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode' Xiongfeng Wang
2020-05-13 19:32 ` Ezequiel Garcia
2020-05-14 1:32 ` Xiongfeng Wang [this message]
2020-05-14 12:54 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b781aa-da2b-5aa7-aadc-a1980c84bd0d@huawei.com \
--to=wangxiongfeng2@huawei.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).