From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/4] ASoC: Intel: bytcht_es8316: Get platform data via dev_get_platdata()
Date: Wed, 6 Oct 2021 10:52:54 -0500 [thread overview]
Message-ID: <c8b85524-6b9f-8fd3-3978-1d26b92660fd@linux.intel.com> (raw)
In-Reply-To: <20211006150428.16434-1-andriy.shevchenko@linux.intel.com>
On 10/6/21 10:04 AM, Andy Shevchenko wrote:
> Access to platform data via dev_get_platdata() getter to make code cleaner.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
For the series
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.com>
FWIW Marc likes a cover letter that's kept in the merge logs.
> ---
> sound/soc/intel/boards/bytcht_es8316.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index 1bb9b8e7bcc7..4360519fbb0c 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -456,12 +456,12 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
>
> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
> static const char * const mic_name[] = { "in1", "in2" };
> + struct snd_soc_acpi_mach *mach = dev_get_platdata(dev);
> struct property_entry props[MAX_NO_PROPS] = {};
> struct byt_cht_es8316_private *priv;
> const struct dmi_system_id *dmi_id;
> - struct device *dev = &pdev->dev;
> - struct snd_soc_acpi_mach *mach;
> struct fwnode_handle *fwnode;
> const char *platform_name;
> struct acpi_device *adev;
> @@ -476,7 +476,6 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - mach = dev->platform_data;
> /* fix index of codec dai */
> for (i = 0; i < ARRAY_SIZE(byt_cht_es8316_dais); i++) {
> if (!strcmp(byt_cht_es8316_dais[i].codecs->name,
>
next prev parent reply other threads:[~2021-10-06 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 15:04 [PATCH v1 1/4] ASoC: Intel: bytcht_es8316: Get platform data via dev_get_platdata() Andy Shevchenko
2021-10-06 15:04 ` [PATCH v1 2/4] ASoC: Intel: bytcht_es8316: Use temporary variable for struct device Andy Shevchenko
2021-10-06 15:04 ` [PATCH v1 3/4] ASoC: Intel: bytcht_es8316: Switch to use gpiod_get_optional() Andy Shevchenko
2021-10-06 15:04 ` [PATCH v1 4/4] ASoC: Intel: bytcht_es8316: Utilize dev_err_probe() to avoid log saturation Andy Shevchenko
2021-10-06 15:52 ` Pierre-Louis Bossart [this message]
2021-10-06 16:25 ` [PATCH v1 1/4] ASoC: Intel: bytcht_es8316: Get platform data via dev_get_platdata() Andy Shevchenko
2021-10-06 16:25 ` Mark Brown
2021-10-07 7:08 ` Andy Shevchenko
2021-10-07 12:59 ` Pierre-Louis Bossart
2021-10-07 21:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b85524-6b9f-8fd3-3978-1d26b92660fd@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).