From: Neil Armstrong <narmstrong@baylibre.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rc: meson-ir: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 10:14:53 +0200 [thread overview]
Message-ID: <c8b8f064-7887-9608-573c-525799641c6d@baylibre.com> (raw)
In-Reply-To: <20210901055440.7079-1-caihuoqing@baidu.com>
On 01/09/2021 07:54, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/media/rc/meson-ir.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/rc/meson-ir.c b/drivers/media/rc/meson-ir.c
> index dad55950dfc6..4b769111f78e 100644
> --- a/drivers/media/rc/meson-ir.c
> +++ b/drivers/media/rc/meson-ir.c
> @@ -102,7 +102,6 @@ static int meson_ir_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *node = dev->of_node;
> - struct resource *res;
> const char *map_name;
> struct meson_ir *ir;
> int irq, ret;
> @@ -111,8 +110,7 @@ static int meson_ir_probe(struct platform_device *pdev)
> if (!ir)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ir->reg = devm_ioremap_resource(dev, res);
> + ir->reg = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ir->reg))
> return PTR_ERR(ir->reg);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
prev parent reply other threads:[~2021-09-01 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 5:54 [PATCH] media: rc: meson-ir: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 8:14 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b8f064-7887-9608-573c-525799641c6d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=caihuoqing@baidu.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).