From: tanhuazhong <tanhuazhong@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
<yisen.zhuang@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration
Date: Mon, 9 Nov 2020 08:57:50 +0800 [thread overview]
Message-ID: <c9249ca4-db17-bd86-66ce-e860fd445a0b@huawei.com> (raw)
In-Reply-To: <20201107094613.261fe05b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2020/11/8 1:46, Jakub Kicinski wrote:
> On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote:
>> For device whose version is above V3(include V3), the GL
>> configuration can set as 1us unit, so adds support for
>> configuring this field.
>>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>
> Doesn't build.
>
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function ‘hns3_check_gl_coalesce_para’:
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1152:6: error: ‘ae_dev’ undeclared (first use in this function); did you mean ‘netdev’?
> 1152 | if (ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V3)
> | ^~~~~~
> | netdev
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1152:6: note: each undeclared identifier is reported only once for each function it appears in
> make[6]: *** [drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.o] Error 1
> make[5]: *** [drivers/net/ethernet/hisilicon/hns3] Error 2
> make[4]: *** [drivers/net/ethernet/hisilicon] Error 2
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [drivers/net/ethernet] Error 2
> make[2]: *** [drivers/net] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers] Error 2
> make: *** [__sub-make] Error 2
>
Will fix it.
Thanks.
> .
>
next prev parent reply other threads:[~2020-11-09 0:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 6:31 [PATCH net-next 00/11] net: hns3: updates for -next Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration Huazhong Tan
2020-11-07 17:46 ` Jakub Kicinski
2020-11-09 0:57 ` tanhuazhong [this message]
2020-11-07 6:31 ` [PATCH net-next 03/11] net: hns3: add support for querying maximum value of GL Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 04/11] net: hns3: rename gl_adapt_enable in struct hns3_enet_coalesce Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 05/11] net: hns3: add support for dynamic interrupt moderation Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 06/11] net: hns3: add ethtool priv-flag for DIM Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 07/11] net: hns3: add hns3_state_init() to do state initialization Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 08/11] net: hns3: add a check for ethtool priv-flag interface Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 09/11] net: hns3: add support for EQ/CQ mode configuration Huazhong Tan
2020-11-07 6:31 ` [PATCH net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ Huazhong Tan
2020-11-07 17:47 ` Jakub Kicinski
2020-11-09 0:58 ` tanhuazhong
2020-11-07 6:31 ` [PATCH net-next 11/11] net: hns3: add debugfs support for interrupt coalesce Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9249ca4-db17-bd86-66ce-e860fd445a0b@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).