From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B187EC2B9F4 for ; Fri, 25 Jun 2021 05:25:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B7766140A for ; Fri, 25 Jun 2021 05:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbhFYF1v (ORCPT ); Fri, 25 Jun 2021 01:27:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30699 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbhFYF1t (ORCPT ); Fri, 25 Jun 2021 01:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624598729; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5TebrKn3e3TKUvfSmuIpNlgqZKelIpKqLqrwtlWlah0=; b=XOoCGr7jyxN1oRC5VbFEXvDySeUoLCItMDioNloKXiz55UCDHsu8I77keaN0qsms1pQgJg 4uvF2IdkP9bxYQ4Vo8xYGXCj0Wrm8BhrBQAHioFwbrFfLRSSZVxdLyfJ5kz48k2ZlybrsV XaAAAXzHF8BRuLU7yCb6XW+hPXboQoA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-u10RwiyANZyT_hriyhl8nw-1; Fri, 25 Jun 2021 01:25:25 -0400 X-MC-Unique: u10RwiyANZyT_hriyhl8nw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5588D802C80; Fri, 25 Jun 2021 05:25:24 +0000 (UTC) Received: from [10.64.54.233] (vpn2-54-233.bne.redhat.com [10.64.54.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42E8360936; Fri, 25 Jun 2021 05:25:21 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v3] Documentation, dt, numa: Add note to empty NUMA node To: Randy Dunlap , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org, drjones@redhat.com, shan.gavin@gmail.com References: <20210625043025.47469-1-gshan@redhat.com> <874bcd17-29b6-658b-fa11-7854b1300d30@infradead.org> <2973ca46-c092-3ffe-b14a-7481e479012e@redhat.com> <3e7eb6ca-6f4c-2a85-8ff2-f7daf186d7a1@infradead.org> From: Gavin Shan Message-ID: Date: Fri, 25 Jun 2021 15:25:19 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <3e7eb6ca-6f4c-2a85-8ff2-f7daf186d7a1@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/21 2:49 PM, Randy Dunlap wrote: > On 6/24/21 9:32 PM, Gavin Shan wrote: >> On 6/25/21 1:47 PM, Randy Dunlap wrote: >>> On 6/24/21 9:30 PM, Gavin Shan wrote: >>>> The empty NUMA nodes, where no memory resides in, are allowed. For >>>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These >>>> empty NUMA node IDs are still valid and parsed. I finds difficulty >>>> to get where it's properly documented. >>>> >>>> So lets add note to empty NUMA nodes in the NUMA binding doc. >>>> >>>> Signed-off-by: Gavin Shan >>>> --- >>>>   Documentation/devicetree/bindings/numa.txt | 4 ++++ >>>>   1 file changed, 4 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt >>>> index 21b35053ca5a..edf728cff155 100644 >>>> --- a/Documentation/devicetree/bindings/numa.txt >>>> +++ b/Documentation/devicetree/bindings/numa.txt >>>> @@ -109,6 +109,10 @@ Example: >>>>   Dual socket system consists of 2 boards connected through ccn bus and >>>>   each board having one socket/soc of 8 cpus, memory and pci bus. >>>>   +Note that the empty NUMA nodes, which no memory resides in, are allowed. >>> >>> I would write that without "the": >>> >>> +Note that empty NUMA nodes, which no memory resides in, are allowed. >>> >>> BTW, AFAIK, NUMA nodes may contain memory, CPU(s), or I/O -- any one, two, or >>> three, without the other types of resources being present. >>> >> >> Sure, I will drop "the" in v4. >> >> The NUMA nodes here are memory nodes here. Since the NUMA node usually means >> memory node. I'm not sure if I change the term "NUMA node" to "NUMA memory >> node" in v4. If you agree, I would have something like this: >> >> Note that empty memory nodes, which no memory resides in, are allowed. >> The NUMA node IDs in these empty memory nodes are still valid, but memory >> can be added into them through hotplug afterwards. > > OK, that sounds fine to me. > Thanks, Randy. I just posted v4 to include the changes. Thanks, Gavin