From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbdGQEvJ (ORCPT ); Mon, 17 Jul 2017 00:51:09 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.178]:17818 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbdGQEvI (ORCPT ); Mon, 17 Jul 2017 00:51:08 -0400 Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() To: myungjoo.ham@gmail.com, Chanwoo Choi References: <20170630071522.GA20486@embeddedgus> <5956057D.3070704@samsung.com> Cc: Kyungmin Park , Linux PM list , LKML From: "Gustavo A. R. Silva" Message-ID: Date: Sun, 16 Jul 2017 23:50:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxzQ-003Cxo-6d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39764 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 73 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2017 02:50 AM, MyungJoo Ham wrote: > On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >>> Print and propagate the return value of platform_get_irq on failure. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/devfreq/rk3399_dmc.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>> index 40a2499..1b89ebb 100644 >>> --- a/drivers/devfreq/rk3399_dmc.c >>> +++ b/drivers/devfreq/rk3399_dmc.c >>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >>> >>> irq = platform_get_irq(pdev, 0); >>> if (irq < 0) { >>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >>> - return -EINVAL; >>> + dev_err(&pdev->dev, >>> + "Cannot get the dmc interrupt resource: %d\n", irq); >>> + return irq; >>> } >>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >>> if (!data) >>> >> >> Reviewed-by: Chanwoo Choi > > Acked-by: MyungJoo Ham > Thank you, Chanwoo and MyungJoo. -- Gustavo A. R. Silva