From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEDFC433F5 for ; Tue, 22 Mar 2022 07:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbiCVHgF (ORCPT ); Tue, 22 Mar 2022 03:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237601AbiCVHff (ORCPT ); Tue, 22 Mar 2022 03:35:35 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5BDA275C8 for ; Tue, 22 Mar 2022 00:34:01 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nWZ1M-0007uz-8w; Tue, 22 Mar 2022 08:33:36 +0100 Message-ID: Date: Tue, 22 Mar 2022 08:33:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 4/4] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys Content-Language: en-US To: Jarkko Sakkinen Cc: Jonathan Corbet , David Howells , James Bottomley , Mimi Zohar , kernel@pengutronix.de, David Gstir , Pankaj Gupta , Tim Harvey , Matthias Schiffer , James Morris , "Serge E. Hallyn" , =?UTF-8?Q?Horia_Geant=c4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , Eric Biggers , Jan Luebbe , Richard Weinberger , Franck LENORMAND , Sumit Garg , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20220316164335.1720255-1-a.fatoum@pengutronix.de> <20220316164335.1720255-5-a.fatoum@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jarkko, On 20.03.22 22:02, Jarkko Sakkinen wrote: > On Wed, Mar 16, 2022 at 05:43:35PM +0100, Ahmad Fatoum wrote: >> @@ -192,6 +217,19 @@ Usage:: >> specific to TEE device implementation. The key length for new keys is always >> in bytes. Trusted Keys can be 32 - 128 bytes (256 - 1024 bits). >> >> +Trusted Keys usage: CAAM >> +------------------------ >> + >> +Usage:: >> + >> + keyctl add trusted name "new keylen" ring >> + keyctl add trusted name "load hex_blob" ring >> + keyctl print keyid >> + >> +"keyctl print" returns an ASCII hex copy of the sealed key, which is in format >> +specific to CAAM device implementation. The key length for new keys is always >> +in bytes. Trusted Keys can be 32 - 128 bytes (256 - 1024 bits). >> + >> Encrypted Keys usage >> -------------------- >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 05fd080b82f3..f13382a14967 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -10647,6 +10647,15 @@ S: Supported >> F: include/keys/trusted_tee.h >> F: security/keys/trusted-keys/trusted_tee.c >> >> +KEYS-TRUSTED-CAAM >> +M: Ahmad Fatoum >> +R: Pengutronix Kernel Team >> +L: linux-integrity@vger.kernel.org >> +L: keyrings@vger.kernel.org >> +S: Maintained >> +F: include/keys/trusted_caam.h >> +F: security/keys/trusted-keys/trusted_caam.c >> + >> KEYS/KEYRINGS >> M: David Howells >> M: Jarkko Sakkinen > > Documentation and MAINTAINERS updates must be separate patches. I will do so for v7. Does this patch look otherwise ok to you? Thanks, Ahmad > > BR, Jarkko > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |