From: Hauke Mehrtens <hauke@hauke-m.de>
To: Aleksander Jan Bajkowski <olek2@wp.pl>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: lantiq: disable interrupt before sheduling NAPI
Date: Tue, 8 Jun 2021 23:33:34 +0200 [thread overview]
Message-ID: <c951fd28-443e-9445-0be3-b134c888f4dc@hauke-m.de> (raw)
In-Reply-To: <20210608212107.222690-1-olek2@wp.pl>
On 6/8/21 11:21 PM, Aleksander Jan Bajkowski wrote:
> This patch fixes TX hangs with threaded NAPI enabled. The scheduled
> NAPI seems to be executed in parallel with the interrupt on second
> thread. Sometimes it happens that ltq_dma_disable_irq() is executed
> after xrx200_tx_housekeeping(). The symptom is that TX interrupts
> are disabled in the DMA controller. As a result, the TX hangs after
> a few seconds of the iperf test. Scheduling NAPI after disabling
> interrupts fixes this issue.
>
> Tested on Lantiq xRX200 (BT Home Hub 5A).
>
> Fixes: 9423361da523 ("net: lantiq: Disable IRQs only if NAPI gets scheduled ")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/ethernet/lantiq_xrx200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 36dc3e5f6218..0e10d8aeffe1 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -352,8 +352,8 @@ static irqreturn_t xrx200_dma_irq(int irq, void *ptr)
> struct xrx200_chan *ch = ptr;
>
> if (napi_schedule_prep(&ch->napi)) {
> - __napi_schedule(&ch->napi);
> ltq_dma_disable_irq(&ch->dma);
> + __napi_schedule(&ch->napi);
> }
>
> ltq_dma_ack_irq(&ch->dma);
>
next prev parent reply other threads:[~2021-06-08 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 21:21 [PATCH net] net: lantiq: disable interrupt before sheduling NAPI Aleksander Jan Bajkowski
2021-06-08 21:33 ` Hauke Mehrtens [this message]
2021-06-09 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c951fd28-443e-9445-0be3-b134c888f4dc@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).