linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: Christoph Jaeger <cj@linux.com>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"
Date: Tue, 26 Jan 2021 19:02:20 -0800	[thread overview]
Message-ID: <c973355e545bcdc52b619f2d13bfa41915074307.camel@perches.com> (raw)
In-Reply-To: <20210126191541.210168-1-masahiroy@kernel.org>

On Wed, 2021-01-27 at 04:15 +0900, Masahiro Yamada wrote:
> This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
> 
> You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
> 'boolean' keyword").
> 
> This check is no longer needed.

Thanks.

> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Joe Perches <joe@perches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3390,13 +3390,6 @@ sub process {
>  			}
>  		}
>  
> -# discourage the use of boolean for type definition attributes of Kconfig options
> -		if ($realfile =~ /Kconfig/ &&
> -		    $line =~ /^\+\s*\bboolean\b/) {
> -			WARN("CONFIG_TYPE_BOOLEAN",
> -			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> -		}
> -
>  		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
>  		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
>  			my $flag = $1;



  reply	other threads:[~2021-01-27  4:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 19:15 [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions" Masahiro Yamada
2021-01-27  3:02 ` Joe Perches [this message]
2021-01-28  6:39   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c973355e545bcdc52b619f2d13bfa41915074307.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=cj@linux.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).