From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448AbcGAHET (ORCPT ); Fri, 1 Jul 2016 03:04:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:12721 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbcGAHER (ORCPT ); Fri, 1 Jul 2016 03:04:17 -0400 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: xyjxie@linux.vnet.ibm.com X-IBM-RcptTo: linux-doc@vger.kernel.org;linux-kernel@vger.kernel.org;linux-pci@vger.kernel.org Subject: Re: [PATCH v3 5/7] PCI: Do not use IORESOURCE_STARTALIGN to identify bridge resources To: Gavin Shan References: <1467283993-3185-1-git-send-email-xyjxie@linux.vnet.ibm.com> <1467283993-3185-6-git-send-email-xyjxie@linux.vnet.ibm.com> <20160701023423.GB6739@gwshan> Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, bhelgaas@google.com, alex.williamson@redhat.com, aik@ozlabs.ru, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, corbet@lwn.net, warrier@linux.vnet.ibm.com, zhong@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com From: Yongji Xie Date: Fri, 1 Jul 2016 15:04:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160701023423.GB6739@gwshan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070107-0016-0000-0000-000001AD58A7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070107-0017-0000-0000-000004EEE4F0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-01_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607010069 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gavin, On 2016/7/1 10:34, Gavin Shan wrote: > On Thu, Jun 30, 2016 at 06:53:11PM +0800, Yongji Xie wrote: >> Now we use the IORESOURCE_STARTALIGN to identify bridge resources >> in __assign_resources_sorted(). That's quite fragile. We may also >> set flag IORESOURCE_STARTALIGN for SR-IOV resources in some cases, >> for example, using the option "noresize" of parameter >> "pci=resource_alignment". >> >> In this patch, we try to use a more robust way to identify >> bridge resources. >> >> Signed-off-by: Yongji Xie > Reviewed-by: Gavin Shan > > Yongji, I think this doesn't have to be part of this series, meaning > it can be sent or merged separately. > Seems like I give a wrong example in my changelog. The parameter "pci=resource_alignment" would not set flag IORESOURCE_STARTALIGN for SR-IOV resources as I replied to you in previous patch. So this patch has nothing to do with this series now, I will remove it as you suggested. Thanks, Yongji