From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051AbdDQPJO (ORCPT ); Mon, 17 Apr 2017 11:09:14 -0400 Received: from mout.web.de ([217.72.192.78]:58032 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbdDQPJL (ORCPT ); Mon, 17 Apr 2017 11:09:11 -0400 Subject: [PATCH 01/25] net: mvneta: Use devm_kmalloc_array() in mvneta_init() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 17 Apr 2017 17:08:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qh4bLLyfZnXGnNkfzssK0Rs4kSgk4mFkbNwSsl5WLSb9p9jCAoD 9jTC/e7diA0reZodCZ9H4t1CEj7i5XJTBxnUKEkR4q2jC6hAbS6Hh4YuECHPfZ2C6bJjLFA JnwoeUnQKrr8UIrEOaorB7jlqt31ZuHgo6VnrAMslN5T/YBxTvXTAvDq98xj0qh/ZxGs0pL lOwo26ARjSiqqkINMi4Eg== X-UI-Out-Filterresults: notjunk:1;V01:K0:dfisICPk5xk=:VIiBqxiLbF4GNlcL7KbuBG Tvb2Y3aghfOByG3R+lhTDCDJmO5Qzzmn9lZQltMPesDgcqKeCsgiMPmsu3FoDDgVL55tiEOOW 0LUlb2XKV7P18d6JRRwohoXEfohfHXHe9BtFhs0X4OWUMF+I2qz+eFmuBfniICdlGBsAZhAOx GWf11amDIchoHes7gGh7LM+B4zgFVMw7A0Sze40UXS8RnJ1qsdf1WDaAyaBN2iCN1fOrG3Eao jZ7wz5lUAivQUs6TwzlGdHJ4XZw2+COB+yXhdp9u4eFpSezkCL1KTby55e1SdY8zdWHUwt9kE fUuWhqVoad+ajlkWOVK94yHVf1ngh1jGkyQTmO7kegKfNotLkSPtPtEFtQuF2Si+pVcUzYp2H 8VWVnOOg4126KMtFCU1xGvyjQTFBNYokXNLTEaPnQRqApeqLseOzbq7ZK6x68EGVlRAi5HTXc ynbWXX7VdENkNWH2sVy4qeY7t+5rOXnXEsgDtn5AkyBITmVz0+q3advvk/x7OYPW7gVPi0Q2Y qP7pBhGdCoOimFd4a9PUCKCJAhkUl2+73+hsIzTL04G/0gzYlDpdCHYZ+1qQCX3g8aa8zOKlM EjFtJxdsNaySDO11Eca/iSIGNMMDWcpxkhmgULwQXxYRCgLdOSmgH9Nb407V0r8ZoPlFfLtDa SE09e+N7NJ6wV3+0dXzOul0eAc4ZC4KSaVf03jQFrmu2VtvjT1J4ghhDjY4y1Xd/pNW42Y2F3 OgO/68z1AU0YyiKhieeolgkPnQicWtKYZLPoOOtYSBPQjugNOUC6ICe7rr4pKSU4I30PWkLlg NNbC7x2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 16 Apr 2017 21:23:19 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvneta.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 34a3686d2ce6..46fa74e93814 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4017,9 +4017,11 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp) rxq->size = pp->rx_ring_size; rxq->pkts_coal = MVNETA_RX_COAL_PKTS; rxq->time_coal = MVNETA_RX_COAL_USEC; - rxq->buf_virt_addr = devm_kmalloc(pp->dev->dev.parent, - rxq->size * sizeof(void *), - GFP_KERNEL); + rxq->buf_virt_addr + = devm_kmalloc_array(pp->dev->dev.parent, + rxq->size, + sizeof(*rxq->buf_virt_addr), + GFP_KERNEL); if (!rxq->buf_virt_addr) return -ENOMEM; } -- 2.12.2