From: mjz <maijianzhang@allwinnertech.com>
To: LKLM <linux-kernel@vger.kernel.org>
Cc: 付尧 <fuyao@allwinnertech.com>,
"Gyungoh Yoo" <jack.yoo@maxim-ic.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Brown" <broonie@kernel.org>
Subject: [PATCH] mfd: remove max8907 wake_base
Date: Thu, 30 Apr 2020 18:04:52 +0800 [thread overview]
Message-ID: <c97ca4ac78304a44587463584acaf1ba08f0d4ee.1588240814.git.fuyao@allwinnertech.com> (raw)
regmap irqchip should not use wake_base the same as mask_base.
if use enable_irq_wake in drivers can cause mask_base write, cause
the disabled irq to enable.
Signed-off-by: maijianzhang <maijianzhang@allwinnertech.com>
---
drivers/mfd/max8907.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index d44baafd9d14..6346a3985088 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -130,7 +130,6 @@ static const struct regmap_irq_chip max8907_chg_irq_chip = {
.name = "max8907 chg",
.status_base = MAX8907_REG_CHG_IRQ1,
.mask_base = MAX8907_REG_CHG_IRQ1_MASK,
- .wake_base = MAX8907_REG_CHG_IRQ1_MASK,
.irq_reg_stride = MAX8907_REG_CHG_IRQ2 - MAX8907_REG_CHG_IRQ1,
.num_regs = 2,
.irqs = max8907_chg_irqs,
--
2.19.1
next reply other threads:[~2020-04-30 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 10:04 mjz [this message]
2020-05-15 10:42 ` [PATCH] mfd: remove max8907 wake_base Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c97ca4ac78304a44587463584acaf1ba08f0d4ee.1588240814.git.fuyao@allwinnertech.com \
--to=maijianzhang@allwinnertech.com \
--cc=broonie@kernel.org \
--cc=fuyao@allwinnertech.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack.yoo@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).