From: Joe Perches <joe@perches.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linux-kernel@vger.kernel.org, apw@canonical.com
Cc: fbarrat@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines
Date: Sun, 05 Aug 2018 22:07:38 -0700 [thread overview]
Message-ID: <c99001394ca5cb13fefc56d5b854be1f4c7e0624.camel@perches.com> (raw)
In-Reply-To: <20180806035809.24752-1-andrew.donnellan@au1.ibm.com>
On Mon, 2018-08-06 at 13:58 +1000, Andrew Donnellan wrote:
> If a patch contains a commit reference that happens to span 3 lines, e.g.:
>
> ===
> With the optimizations for TLB invalidation from commit 0cef77c7798a
> ("powerpc/64s/radix: flush remote CPUs out of single-threaded
> mm_cpumask"), the scope of a TLBI (global vs. local) can now be
> influenced by the value of the 'copros' counter of the memory context.
> ===
>
> checkpatch will return a GIT_COMMIT_ID error even though the reference
> actually follows the correct format.
The multiple line block code can be difficult to read.
My suggestion is to instead write a subroutine to get the
commit description and compare that against the returned
git commit description.
next prev parent reply other threads:[~2018-08-06 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 3:58 [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines Andrew Donnellan
2018-08-06 3:58 ` [RFC PATCH 2/2] checkpatch: Fix commit ID test when "commit" and hash on different lines Andrew Donnellan
2018-08-06 5:07 ` Joe Perches [this message]
2018-08-06 8:37 ` [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c99001394ca5cb13fefc56d5b854be1f4c7e0624.camel@perches.com \
--to=joe@perches.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=apw@canonical.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).