From: Lyude Paul <lyude@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>,
bskeggs@redhat.com, airlied@linux.ie, daniel@ffwll.ch,
alexander.deucher@amd.com, sam@ravnborg.org
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/nouveau/kms/nv50: remove set but not unused variable 'nv_connector'
Date: Fri, 17 Jan 2020 19:19:00 -0500 [thread overview]
Message-ID: <c99174eefb65688c3db3fc25ddec819a58dccc6a.camel@redhat.com> (raw)
In-Reply-To: <20200117033642.50656-1-yuehaibing@huawei.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2020-01-17 at 11:36 +0800, YueHaibing wrote:
> drivers/gpu/drm/nouveau/dispnv50/disp.c: In function nv50_pior_enable:
> drivers/gpu/drm/nouveau/dispnv50/disp.c:1672:28: warning:
> variable nv_connector set but not used [-Wunused-but-set-variable]
>
> commit ac2d9275f371 ("drm/nouveau/kms/nv50-: Store the
> bpc we're using in nv50_head_atom") left behind this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index 5fabe2b..a82b354 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -1669,7 +1669,6 @@ nv50_pior_enable(struct drm_encoder *encoder)
> {
> struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
> struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
> - struct nouveau_connector *nv_connector;
> struct nv50_head_atom *asyh = nv50_head_atom(nv_crtc->base.state);
> struct nv50_core *core = nv50_disp(encoder->dev)->core;
> u8 owner = 1 << nv_crtc->index;
> @@ -1677,7 +1676,6 @@ nv50_pior_enable(struct drm_encoder *encoder)
>
> nv50_outp_acquire(nv_encoder);
>
> - nv_connector = nouveau_encoder_connector_get(nv_encoder);
> switch (asyh->or.bpc) {
> case 10: asyh->or.depth = 0x6; break;
> case 8: asyh->or.depth = 0x5; break;
--
Cheers,
Lyude Paul
prev parent reply other threads:[~2020-01-18 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 3:36 [PATCH -next] drm/nouveau/kms/nv50: remove set but not unused variable 'nv_connector' YueHaibing
2020-01-18 0:19 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c99174eefb65688c3db3fc25ddec819a58dccc6a.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sam@ravnborg.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).