From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DF8C433FE for ; Thu, 6 Oct 2022 03:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbiJFDJE (ORCPT ); Wed, 5 Oct 2022 23:09:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiJFDJA (ORCPT ); Wed, 5 Oct 2022 23:09:00 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BBBC80F47 for ; Wed, 5 Oct 2022 20:09:00 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4D8A33200917; Wed, 5 Oct 2022 23:08:59 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute3.internal (MEProxy); Wed, 05 Oct 2022 23:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1665025738; x=1665112138; bh=YLPP3ai1CZ bUXBkGYE8FeExSwido5nCV0cHPJQIZgPI=; b=qHWU0SwlVVnJjB+094CvRTb1w6 IKxxEGUwvbAlOp91pDIrd8m71GNQrAXv9OhLyaEp//5FrQUfi4J4x1OxkX7l4o0M 3HeslnRwe1WX03r3zfB5tGCoqd6hBsjeOz/fWiMBF8ad25vmNqFEcAj2vvA5v3Wy xhsy5oGmvzD0zhz7Me1K9piEJW53zGSbcw8NU16zcwt1u+FYFrtK8uIb+2eqJR1i iZmdyhZNxGXGx3hn9UXQWKdNgSCvF+Amm+7nyI9u9JOjivuD51O/k6dCtukQSurh iv/jlUiTlO1/HYJWkkZLUh0Ck0cdoyekgxRs8dZROXxyquzmB+cw/ZUVwPTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1665025738; x=1665112138; bh=YLPP3ai1CZbUXBkGYE8FeExSwido 5nCV0cHPJQIZgPI=; b=TJ7mnv46ihjN1lCqaaKBPvtrx6U+cE38GW8Vaa7CIxbb 09FghGEiiOiBTtQgnn1Xrx+LPnH2GTBBYLn8HEUAvT/jckSTsGMnE7K/3o1F7l79 PQCbdtdSshABmoVI/vsnxgyjWfuHh44BtCSVbTENhyxlbcdHy9kFibB5Y2HYCDWz w5xDMIcce412xIDNjZEQzebiu12TfFxMsmg2KEdtUQdjdpe3+ehmPVglpLJuMHZL WJQRrrdWmGguKmaRqWSGmM/EfvBMUq61/JgJANZVJO2IQVa7GytsdPdCaQNB6uBM Sa45eLRZ8ofAJxHcbMumVm0fPeZ9rtwHFThgtNetUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeigedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtf frrghtthgvrhhnpeekvdekjeekgfejudffteetgeejkeetteduvedtffdtledutdfhheev feetkeeiteenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Feedback-ID: idfb84289:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id AF10E1700083; Wed, 5 Oct 2022 23:08:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1015-gaf7d526680-fm-20220929.001-gaf7d5266 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20220812144741.240315-1-andrew@aj.id.au> <08c20621-e75d-4a72-82e6-b1980304e20a@app.fastmail.com> Date: Thu, 06 Oct 2022 13:38:30 +1030 From: "Andrew Jeffery" To: "Corey Minyard" Cc: openipmi-developer@lists.sourceforge.net, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ipmi: kcs: Poll OBF briefly to reduce OBE latency Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Oct 2022, at 10:24, Corey Minyard wrote: > On Thu, Oct 06, 2022 at 09:42:57AM +1030, Andrew Jeffery wrote: >> Hi Corey, >> >> On Sat, 13 Aug 2022, at 00:17, Andrew Jeffery wrote: >> > The ASPEED KCS devices don't provide a BMC-side interrupt for the host >> > reading the output data register (ODR). The act of the host reading ODR >> > clears the output buffer full (OBF) flag in the status register (STR), >> > informing the BMC it can transmit a subsequent byte. >> > >> > On the BMC side the KCS client must enable the OBE event *and* perform a >> > subsequent read of STR anyway to avoid races - the polling provides a >> > window for the host to read ODR if data was freshly written while >> > minimising BMC-side latency. >> >> Just wondering whether you're happy to pick this one up? I haven't seen >> it hit the IPMI tree yet. > > Sorry. It's in my tree for 6.2 right now. Thanks! > > I can't push it up to for-next until 6.1-rc1 comes out. > No worries, just wanted to make sure it didn't fall through the cracks :) Andrew