From: Mike Kravetz <mike.kravetz@oracle.com>
To: David Hildenbrand <david@redhat.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH mmotm v1] mm/hwpoison: disable pcp for page_handle_poison()
Date: Thu, 17 Jun 2021 21:47:46 -0700 [thread overview]
Message-ID: <c9a5d349-cd3f-2cb3-d16b-7ca3fb679e1a@oracle.com> (raw)
In-Reply-To: <a7367b3b-f772-f147-36fe-fdf67a7aaa60@redhat.com>
On 6/17/21 5:21 AM, David Hildenbrand wrote:
> On 17.06.21 11:26, Naoya Horiguchi wrote:
>> From: Naoya Horiguchi <naoya.horiguchi@nec.com>
>>
>> Recent changes by patch "mm/page_alloc: allow high-order pages to be
>> stored on the per-cpu lists" makes kernels determine whether to use pcp
>> by pcp_allowed_order(), which breaks soft-offline for hugetlb pages.
>>
>> Soft-offline dissolves a migration source page, then removes it from
>> buddy free list, so it's assumed that any subpage of the soft-offlined
>> hugepage are recognized as a buddy page just after returning from
>> dissolve_free_huge_page(). pcp_allowed_order() returns true for
>> hugetlb, so this assumption is no longer true.
>>
>> So disable pcp during dissolve_free_huge_page() and
>> take_page_off_buddy() to prevent soft-offlined hugepages from linking to
>> pcp lists. Soft-offline should not be common events so the impact on
>> performance should be minimal. And I think that the optimization of
>> Mel's patch could benefit to hugetlb so zone_pcp_disable() is called
>> only in hwpoison context.
>>
>> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
>> ---
>> mm/memory-failure.c | 19 ++++++++++++++++---
>> 1 file changed, 16 insertions(+), 3 deletions(-)
>>
>> diff --git v5.13-rc6-mmotm-2021-06-15-20-24/mm/memory-failure.c v5.13-rc6-mmotm-2021-06-15-20-24_patched/mm/memory-failure.c
>> index 1842822a10da..593079766655 100644
>> --- v5.13-rc6-mmotm-2021-06-15-20-24/mm/memory-failure.c
>> +++ v5.13-rc6-mmotm-2021-06-15-20-24_patched/mm/memory-failure.c
>> @@ -66,6 +66,19 @@ int sysctl_memory_failure_recovery __read_mostly = 1;
>> atomic_long_t num_poisoned_pages __read_mostly = ATOMIC_LONG_INIT(0);
>> +static bool __page_handle_poison(struct page *page)
>> +{
>> + bool ret;
>> +
>> + zone_pcp_disable(page_zone(page));
>> + ret = dissolve_free_huge_page(page);
>> + if (!ret)
>> + ret = take_page_off_buddy(page);
>> + zone_pcp_enable(page_zone(page));
>> +
>> + return ret;
>> +}
>> +
>> static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, bool release)
>> {
>> if (hugepage_or_freepage) {
>> @@ -73,7 +86,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo
>> * Doing this check for free pages is also fine since dissolve_free_huge_page
>> * returns 0 for non-hugetlb pages as well.
>> */
>> - if (dissolve_free_huge_page(page) || !take_page_off_buddy(page))
>> + if (!__page_handle_poison(page))
>> /*
>> * We could fail to take off the target page from buddy
>> * for example due to racy page allocation, but that's
>> @@ -986,7 +999,7 @@ static int me_huge_page(struct page *p, unsigned long pfn)
>> */
>> if (PageAnon(hpage))
>> put_page(hpage);
>> - if (!dissolve_free_huge_page(p) && take_page_off_buddy(p)) {
>> + if (__page_handle_poison(p)) {
>> page_ref_inc(p);
>> res = MF_RECOVERED;
>> }
>> @@ -1441,7 +1454,7 @@ static int memory_failure_hugetlb(unsigned long pfn, int flags)
>> res = get_hwpoison_page(p, flags);
>> if (!res) {
>> res = MF_FAILED;
>> - if (!dissolve_free_huge_page(p) && take_page_off_buddy(p)) {
>> + if (__page_handle_poison(p)) {
>> page_ref_inc(p);
>> res = MF_RECOVERED;
>> }
>>
>
> Just to make sure: all call paths are fine that we are taking a mutex, right?
>
That should be the case. dissolve_free_huge_page can sleep, so if not
we are already broken.
--
Mike Kravetz
prev parent reply other threads:[~2021-06-18 4:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 9:26 [PATCH mmotm v1] mm/hwpoison: disable pcp for page_handle_poison() Naoya Horiguchi
2021-06-17 9:28 ` David Hildenbrand
2021-06-17 11:16 ` Mel Gorman
2021-06-17 11:15 ` Mel Gorman
2021-06-17 12:21 ` David Hildenbrand
2021-06-18 4:47 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9a5d349-cd3f-2cb3-d16b-7ca3fb679e1a@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).