From: shuah <shuah@kernel.org>
To: Dmitry Safonov <dima@arista.com>
Cc: linux-kselftest@vger.kernel.org, avagin@gmail.com,
linux-kernel@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests: use LDLIBS for libraries instead of LDFLAGS
Date: Thu, 13 Feb 2020 13:24:22 -0700 [thread overview]
Message-ID: <c9b248a3-8df5-a76d-b472-9e65d837cf5c@kernel.org> (raw)
In-Reply-To: <db01c4e9-c236-3847-f812-943e4442f048@kernel.org>
On 2/12/20 11:15 AM, shuah wrote:
> On 2/12/20 7:00 AM, Dmitry Safonov wrote:
>> While building selftests, the following errors were observed:
>>> tools/testing/selftests/timens'
>>> gcc -Wall -Werror -pthread -lrt -ldl timens.c -o
>>> tools/testing/selftests/timens/timens
>>> /usr/bin/ld: /tmp/ccGy5CST.o: in function `check_config_posix_timers':
>>> timens.c:(.text+0x65a): undefined reference to `timer_create'
>>> collect2: error: ld returned 1 exit status
>>
>> Quoting commit 870f193d48c2 ("selftests: net: use LDLIBS instead of
>> LDFLAGS"):
>>
>> The default Makefile rule looks like:
>>
>> $(CC) $(CFLAGS) $(LDFLAGS) $@ $^ $(LDLIBS)
>>
>> When linking is done by gcc itself, no issue, but when it needs to be
>> passed
>> to proper ld, only LDLIBS follows and then ld cannot know what libs to
>> link
>> with.
>>
>> More detail:
>> https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
>>
>>
>> LDFLAGS
>> Extra flags to give to compilers when they are supposed to invoke the
>> linker,
>> ‘ld’, such as -L. Libraries (-lfoo) should be added to the LDLIBS
>> variable
>> instead.
>>
>> LDLIBS
>> Library flags or names given to compilers when they are supposed to
>> invoke the
>> linker, ‘ld’. LOADLIBES is a deprecated (but still supported)
>> alternative to
>> LDLIBS. Non-library linker flags, such as -L, should go in the LDFLAGS
>> variable.
>>
>> While at here, correct other selftests, not only timens ones.
>>
>> Reported-by: Shuah Khan <skhan@kernel.org>
>> Signed-off-by: Dmitry Safonov <dima@arista.com>
>> ---
>> tools/testing/selftests/futex/functional/Makefile | 2 +-
>> tools/testing/selftests/net/Makefile | 4 ++--
>> tools/testing/selftests/rtc/Makefile | 2 +-
>> tools/testing/selftests/timens/Makefile | 2 +-
>> 4 files changed, 5 insertions(+), 5 deletions(-)
>>
>
>
> Looks good. Thanks for fixing it quickly.
>
> Please split these into 4 patches and send one for each test.
>
> For timens:
>
> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>
In the interest of getting this fix in, I applied it to
git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
fixes branch.
No need to do anything.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-02-13 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 14:00 [PATCH] selftests: use LDLIBS for libraries instead of LDFLAGS Dmitry Safonov
2020-02-12 18:15 ` shuah
2020-02-13 20:24 ` shuah [this message]
2020-02-13 20:25 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b248a3-8df5-a76d-b472-9e65d837cf5c@kernel.org \
--to=shuah@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).