From: Saravanan Sekar <sravanhome@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: afaerber@suse.de, sboyd@kernel.org, pn@denx.de,
linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings
Date: Sun, 1 Jul 2018 19:54:00 +0200 [thread overview]
Message-ID: <c9c737ff-c94f-a508-2cf7-a12456ec9e8a@gmail.com> (raw)
In-Reply-To: <20180701173706.GA15895@Mani-XPS-13-9360>
Hi Mani,
On 07/01/18 19:37, Manivannan Sadhasivam wrote:
> On Sun, Jul 01, 2018 at 07:26:20PM +0200, Saravanan Sekar wrote:
>> Hi Mani
>>
>>
>> On 06/30/18 11:32, Manivannan Sadhasivam wrote:
>>> Hi Saravanan,
>>>
>>> I agree with modifying the existing binding to accomodate other
>>> SoC's of the same family. But the binding should be
>>> "actions,owl-cmu.txt" since it reflects the family name.
>> Agree, will modify the name
>>
>>> Andreas, what do you think?
>>>
>>> On Thu, Jun 28, 2018 at 09:18:05PM +0200, Saravanan Sekar wrote:
>>>> Modify clock bindings common Actions Semi Soc family S700/S900.
>>>>
>>>> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
>>>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>>>> ---
>>>> ...tions,s900-cmu.txt => actions,sx00-cmu.txt} | 18 ++++++++++--------
>>>> 1 file changed, 10 insertions(+), 8 deletions(-)
>>>> rename Documentation/devicetree/bindings/clock/{actions,s900-cmu.txt => actions,sx00-cmu.txt} (71%)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/clock/actions,s900-cmu.txt b/Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
>>>> similarity index 71%
>>>> rename from Documentation/devicetree/bindings/clock/actions,s900-cmu.txt
>>>> rename to Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
>>>> index 93e4fb827cd6..8dc7edb4d198 100644
>>>> --- a/Documentation/devicetree/bindings/clock/actions,s900-cmu.txt
>>>> +++ b/Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
>>>> @@ -1,12 +1,14 @@
>>>> -* Actions S900 Clock Management Unit (CMU)
>>>> +* Actions S900/S700 Clock Management Unit (CMU)
>>> Same as above. Should be Actions OWL SoC's Clock Management Unit (CMU).
>> sure
>>
> During the review of I2C controller driver, Andreas pointed out that
> we should use Owl instead of OWL in all places and also Actions should
> be replaced by Actions Semiconductor. So, please change it in relevant
> places. For this binding, title should be:
>
> Actions Semiconductor Owl SoC's Clock Management Unit (CMU).
Ok will change as mentioned above.
> Thanks,
> Mani
>
>>>> -The Actions S900 clock management unit generates and supplies clock to various
>>>> -controllers within the SoC. The clock binding described here is applicable to
>>>> -S900 SoC.
>>>> +The Actions S900/S700 clock management unit generates and supplies clock to
>>>> +various controllers within the SoC. The clock binding described here is
>>>> +applicable to S900/S700 SoC.
>>>> Required Properties:
>>>> -- compatible: should be "actions,s900-cmu"
>>>> +- compatible: should be one of this
>>> Change to: compatible: should be one of the following:
>> sure
>>
>>> Thanks,
>>> Mani
>>>
>>>> + "actions,s900-cmu"
>>>> + "actions,s700-cmu"
>>>> - reg: physical base address of the controller and length of memory mapped
>>>> region.
>>>> - clocks: Reference to the parent clocks ("hosc", "losc")
>>>> @@ -15,9 +17,9 @@ Required Properties:
>>>> Each clock is assigned an identifier, and client nodes can use this identifier
>>>> to specify the clock which they consume.
>>>> -All available clocks are defined as preprocessor macros in
>>>> -dt-bindings/clock/actions,s900-cmu.h header and can be used in device
>>>> -tree sources.
>>>> +All available clocks are defined as preprocessor macros in corresponding
>>>> +dt-bindings/clock/actions,s900-cmu.h or s700-cmu.h header and can be used in
>>>> +device tree sources.
>>>> External clocks:
>>>> --
>>>> 2.18.0
>>>>
>> Thanks,
>> Saravanan
next prev parent reply other threads:[~2018-07-01 17:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 19:28 [PATCH 0/2] Add clock driver for Actions S700 SoC Saravanan Sekar
2018-06-26 19:28 ` [PATCH 1/2] arm64: dts: actions: Enable clock controller for S700 Saravanan Sekar
2018-06-26 19:28 ` [PATCH 2/2] clk: actions: Add S700 SoC clock support Saravanan Sekar
2018-06-27 6:06 ` kbuild test robot
2018-06-27 6:06 ` kbuild test robot
2018-06-28 19:18 ` [PATCH v2 0/3] Add clock driver for Actions S700 SoC Saravanan Sekar
2018-06-28 19:18 ` [PATCH v2 1/3] arm64: dts: actions: Enable clock controller for S700 Saravanan Sekar
2018-06-29 17:36 ` Stephen Boyd
2018-06-29 17:38 ` Andreas Färber
2018-07-01 16:50 ` Saravanan Sekar
2018-06-30 9:42 ` Manivannan Sadhasivam
2018-07-01 17:50 ` Saravanan Sekar
2018-07-02 2:33 ` Manivannan Sadhasivam
2018-06-28 19:18 ` [PATCH v2 2/3] clk: actions: Add S700 SoC clock support Saravanan Sekar
2018-06-30 9:22 ` Manivannan Sadhasivam
2018-07-01 17:23 ` Saravanan Sekar
2018-07-01 17:30 ` Manivannan Sadhasivam
2018-07-01 17:52 ` Saravanan Sekar
2018-06-28 19:18 ` [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings Saravanan Sekar
2018-06-30 9:32 ` Manivannan Sadhasivam
2018-07-01 17:26 ` Saravanan Sekar
2018-07-01 17:37 ` Manivannan Sadhasivam
2018-07-01 17:54 ` Saravanan Sekar [this message]
2018-07-01 17:58 ` Andreas Färber
2018-07-02 2:02 ` Manivannan Sadhasivam
2018-06-29 17:38 ` [PATCH v2 0/3] Add clock driver for Actions S700 SoC Stephen Boyd
2018-07-01 16:53 ` Saravanan Sekar
2018-07-01 18:05 ` Andreas Färber
2018-07-01 18:24 ` Parthiban Nallathambi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c737ff-c94f-a508-2cf7-a12456ec9e8a@gmail.com \
--to=sravanhome@gmail.com \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).