From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C58C4338F for ; Tue, 24 Aug 2021 19:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5123761374 for ; Tue, 24 Aug 2021 19:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234298AbhHXTF5 (ORCPT ); Tue, 24 Aug 2021 15:05:57 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:35160 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234114AbhHXTFx (ORCPT ); Tue, 24 Aug 2021 15:05:53 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 23CA24079D for ; Tue, 24 Aug 2021 19:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629831906; bh=imZyE0myVr/4RzrKTOaKGpxnnbHBTwOKB1lVbc5Dymc=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=cnhpg2ZWLmCR8OrIBiLeomleHCwq0FuLx4YSn3qHatIVc6m4dOUfP4p2H6+3N4ZJS i2x/gTxtls6I5xA0fGmcBJ9p+DYinTX9PUm0i16dcj8dJiQrfF1Ts+//SINmSjzfBt KT4jfK95B/y97STDk5igWpsciJQbCVGtAtA9sIotBgz3TS8kwe554Em4+ugRvBmY1z U/fvyBwzyQMfHV6fmPPnHkA1kdp8biNhZHNUqE0b1l/VdC6xHslPxovJQg5kCru1Pe mzQc0B9PAhpKevEFkdwR92jWj+62KaBD45Le8PgqRcq8yr9ZBMpPMpexndmB/ALh87 dwDzrFuwczZqw== Received: by mail-wm1-f69.google.com with SMTP id m22-20020a7bca56000000b002e7508f3faeso1853039wml.2 for ; Tue, 24 Aug 2021 12:05:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=imZyE0myVr/4RzrKTOaKGpxnnbHBTwOKB1lVbc5Dymc=; b=CjIyYnjC7uL5iWG/GN5LQrxJeqB5qOYL4ZSlnzCsITUbPzAGFF5xSZsLeser2crzCT Itu2QTwOpidLsw2qvAP6voGCxpGHBYhKe8TtNZa0fSiTrGHyHtpuueOkSsAx1qMAOgk0 7kxv6Mno5+Kk2wN+95uHkqQABQwXHYMFM12PxJ/8/cFbcMqnDCGfNkVp8ObEig5amzS2 pCN31g38LkyTKxbJ48w+jWtSu1HkjkibgPorrcrAGj/FpJ02sfhBUIhhmuvN1OIjvfhh LXKeMvOKqUtkkepT+Cw2x1bpgLFsyCbPX5jgi+MpBKrakgyWdWWiMcyHFACUB/+JA/HS Yy9Q== X-Gm-Message-State: AOAM532qCxh/bTGIeHh4DiuY6A8/lfajf3I5T/rqgKS7CqbX+hdd50a4 nHn3gloIb5NPW9rtrQH/tjVAAu/L45aYAlAC71SB7s8Wamh8JDT7vaXdgMRePfxjhwOg5on6qzR lPkw/Dvd3an+7K66dFN2Rg7U2Fz2hx4rSUSYlqhKdaQ== X-Received: by 2002:a1c:7413:: with SMTP id p19mr5591081wmc.30.1629831904774; Tue, 24 Aug 2021 12:05:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza/ERSPVmnyN7SqaIwhIMDqCYelq2Xjc/rr4UPcc2KdmL1ksd3r2LvJdQvXH7L1vDQ5Ur3vw== X-Received: by 2002:a1c:7413:: with SMTP id p19mr5591045wmc.30.1629831904577; Tue, 24 Aug 2021 12:05:04 -0700 (PDT) Received: from [192.168.0.103] ([79.98.113.188]) by smtp.gmail.com with ESMTPSA id n14sm14742395wrr.28.2021.08.24.12.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 12:05:04 -0700 (PDT) Subject: Re: [PATCH 4/6] riscv: microchip: mpfs: fix board compatible To: Geert Uytterhoeven Cc: Ulf Hansson , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Geert Uytterhoeven , Atish Patra , Yash Shah , Masahiro Yamada , Piotr Sroka , Linux MMC List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , linux-riscv References: <20210819154436.117798-1-krzysztof.kozlowski@canonical.com> <20210819154436.117798-4-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Tue, 24 Aug 2021 21:05:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/2021 17:29, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Aug 19, 2021 at 5:45 PM Krzysztof Kozlowski > wrote: >> According to bindings, the compatible must include microchip,mpfs. This >> fixes dtbs_check warning: >> >> arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: /: compatible: ['microchip,mpfs-icicle-kit'] is too short >> >> Signed-off-by: Krzysztof Kozlowski > > Thanks for your patch! > >> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts >> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts >> @@ -10,7 +10,7 @@ >> >> / { >> model = "Microchip PolarFire-SoC Icicle Kit"; >> - compatible = "microchip,mpfs-icicle-kit"; >> + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs"; > > I have the same change in my local tree, but didn't get to submit it > yet, so this part is fine ;-) > >> >> chosen { >> stdout-path = &serial0; >> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi >> index b9819570a7d1..cb54da0cc3c4 100644 >> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi >> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi >> @@ -7,7 +7,7 @@ / { >> #address-cells = <2>; >> #size-cells = <2>; >> model = "Microchip MPFS Icicle Kit"; >> - compatible = "microchip,mpfs-icicle-kit"; >> + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs"; > > As this file is the SoC .dtsi, not the board DTS for the full > Icicle Kit, the compatible value should be just "microchip,mpfs" > (to be augmented by the board DTS). > And "model" should be "Microchip PolarFire SoC". Sounds good, I'll fix it in v2. Best regards, Krzysztof