From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968622AbdD0PlT (ORCPT ); Thu, 27 Apr 2017 11:41:19 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35381 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937236AbdD0PlN (ORCPT ); Thu, 27 Apr 2017 11:41:13 -0400 Subject: Re: [PATCH] checkpatch: add --typedefsfile To: Joe Perches , Andy Whitcroft , linux-kernel@vger.kernel.org References: <1492706988.30293.13.camel@perches.com> <573fcc18-c0c4-6fcb-e16b-af4bfe86e75e@linaro.org> Cc: Andrew Morton From: Jerome Forissier Message-ID: Date: Thu, 27 Apr 2017 17:41:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <573fcc18-c0c4-6fcb-e16b-af4bfe86e75e@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/21/2017 08:31 AM, Jerome Forissier wrote: > On 04/20/2017 06:49 PM, Joe Perches wrote: >> On Thu, 2017-04-20 at 17:39 +0200, Jerome Forissier wrote: >>> When using checkpatch on out-of-tree code, it may occur that some >>> project-specific types are used, which will cause spurious warnings. >>> Add the --typedefsfile option as a way to extend the known types and >>> deal with this issue. >> >> I'm not opposed to the addition. >> What out-of-tree project is this for? > > OP-TEE [1]. We run a Travis job on all pull requests [2], and checkpatch > is part of that. The typical false warning we get on a regular basis is > with some pointers to functions returning TEE_Result [3], which is a > typedef from the GlobalPlatform APIs. We consider it is acceptable to > use GP types in the OP-TEE core implementation, that's why this patch > would be helpful for us. > > [1] https://github.com/OP-TEE/optee_os > [2] https://travis-ci.org/OP-TEE/optee_os/builds > [3] https://travis-ci.org/OP-TEE/optee_os/builds/193355335#L1733 Ping?