From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Sridharan, Ranjani" <ranjani.sridharan@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Support Opensource <Support.Opensource@diasemi.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chiang, Mac" <mac.chiang@intel.com>,
Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
"Lu, Brent" <brent.lu@intel.com>,
"cychiang@google.com" <cychiang@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Tue, 11 Feb 2020 15:49:06 -0600 [thread overview]
Message-ID: <c9dbcdd8-b943-94a6-581f-7bbebe8c6d25@linux.intel.com> (raw)
In-Reply-To: <CAFQqKeXK3OG7KXaHGUuC75sxWrdf11xJooC7XsDCOyd6KUgPTQ@mail.gmail.com>
>>> Are you talking about the change in this commit acbf27746ecfa96b
>>> "ASoC: pcm: update FE/BE trigger order based on the command"?
>>>
>>> We made this change to handle xruns during pause/release particularly on
>>> the Intel HDA platforms.
>>
>> this change was just to mirror the behavior between start/stop, I
>> thought there was a patch where we moved to TRIGGER_POST by default?
>>
>> What I am trying to figure out if whether using TRIGGER_PRE is ok or not
>> for the SOF firmware.
>>
>
> Ahh yes, it was part of the same series as this one. fd274c2b7267b "ASoC:
> SOF: topology: set trigger order for FE DAI link"
>
> TRIGGER_PRE won't really work in the case of SOF. We need the BE DAI to be
> triggered before the FE DAI during start to prevent the xruns during
> pause/release.
Thanks Ranjani. That information closes the door on the idea of playing
with the trigger order suggested earlier in the thread, so my guess is
that we really need to expose the MCLK/BCLK with the clk API and turn
them on/off from the machine driver as needed. I hope is that we don't
need the FSYNC as well, that would be rather painful to implement.
next prev parent reply other threads:[~2020-02-11 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 8:16 [PATCH] ASoC: da7219: check SRM lock in trigger callback Brent Lu
2020-02-10 14:18 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAOReqxhHfTuj6mxeX2e_ejMY8N4u+BFLfzKDgn=y5EbWLL_joA@mail.gmail.com>
2020-02-10 16:07 ` Pierre-Louis Bossart
[not found] ` <CAOReqxiNomQ7OOoE8LHWKH_LkaerSgsO-Yr4918Az2e_50THaA@mail.gmail.com>
2020-02-11 4:00 ` Fletcher Woodruff
2020-02-10 14:32 ` Adam Thomson
2020-02-11 10:08 ` Lu, Brent
2020-02-11 16:30 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAFQqKeWHDyyd_YBBaD6P2sCL5OCNEsiUU6B7eUwtiLv8GZU0yg@mail.gmail.com>
2020-02-11 21:12 ` Pierre-Louis Bossart
[not found] ` <CAFQqKeXK3OG7KXaHGUuC75sxWrdf11xJooC7XsDCOyd6KUgPTQ@mail.gmail.com>
2020-02-11 21:49 ` Pierre-Louis Bossart [this message]
2020-02-12 10:16 ` Adam Thomson
2020-02-12 11:59 ` Mark Brown
2020-02-12 15:48 ` Pierre-Louis Bossart
2020-02-12 17:01 ` Adam Thomson
2020-02-19 5:57 ` Lu, Brent
2020-02-19 10:05 ` Adam Thomson
2020-02-10 18:59 ` Mark Brown
2020-02-11 10:19 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9dbcdd8-b943-94a6-581f-7bbebe8c6d25@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cychiang@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=ranjani.sridharan@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).