From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38705C35242 for ; Tue, 11 Feb 2020 21:49:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C6EC2073C for ; Tue, 11 Feb 2020 21:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbgBKVtK (ORCPT ); Tue, 11 Feb 2020 16:49:10 -0500 Received: from mga06.intel.com ([134.134.136.31]:21187 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbgBKVtI (ORCPT ); Tue, 11 Feb 2020 16:49:08 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:49:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="256613513" Received: from lmgarret-mobl2.amr.corp.intel.com (HELO [10.251.152.253]) ([10.251.152.253]) by fmsmga004.fm.intel.com with ESMTP; 11 Feb 2020 13:49:06 -0800 Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback To: "Sridharan, Ranjani" Cc: "alsa-devel@alsa-project.org" , Support Opensource , Takashi Iwai , Liam Girdwood , "linux-kernel@vger.kernel.org" , "Chiang, Mac" , Mark Brown , Ranjani Sridharan , Adam Thomson , "Lu, Brent" , "cychiang@google.com" References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> <855c88fb-4438-aefb-ac9b-a9a5a2dc8caa@linux.intel.com> <2eeca7fe-aec9-c680-5d61-930de18b952b@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 11 Feb 2020 15:49:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Are you talking about the change in this commit acbf27746ecfa96b >>> "ASoC: pcm: update FE/BE trigger order based on the command"? >>> >>> We made this change to handle xruns during pause/release particularly on >>> the Intel HDA platforms. >> >> this change was just to mirror the behavior between start/stop, I >> thought there was a patch where we moved to TRIGGER_POST by default? >> >> What I am trying to figure out if whether using TRIGGER_PRE is ok or not >> for the SOF firmware. >> > > Ahh yes, it was part of the same series as this one. fd274c2b7267b "ASoC: > SOF: topology: set trigger order for FE DAI link" > > TRIGGER_PRE won't really work in the case of SOF. We need the BE DAI to be > triggered before the FE DAI during start to prevent the xruns during > pause/release. Thanks Ranjani. That information closes the door on the idea of playing with the trigger order suggested earlier in the thread, so my guess is that we really need to expose the MCLK/BCLK with the clk API and turn them on/off from the machine driver as needed. I hope is that we don't need the FSYNC as well, that would be rather painful to implement.